Make conj interface more flexible #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failed tests is not relevant, which is related to some change in SymbolicUtils. 30 dependencies successfully precompiled in 25 seconds. 43 already precompiled.
1 dependency had warnings during precompilation:
┌ SymEngineSymbolicUtilsExt [9cfbb343-ecf1-584a-98a6-9923b893d35f]
│ WARNING: could not import SymbolicUtils.cmp_mul_adds into SymEngineSymbolicUtilsExt
│ WARNING: could not import SymbolicUtils.cmp_term_term into SymEngineSymbolicUtilsExt
└ |
|
Hi, is it possible to get this PR merged and tag a new version? Otherwise, the following PR in Yao will be block by this PR: |
|
Yes, working on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to extend the
conjfunction for the quantum simulator Yao. However, the original interface is not allowed to overwrite.