Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type declarations #283

Closed
dbu opened this issue Dec 13, 2021 · 1 comment
Closed

type declarations #283

dbu opened this issue Dec 13, 2021 · 1 comment
Milestone
3.0

Comments

@dbu
Copy link
Member

dbu commented Dec 13, 2021

upgrade code to best practices

  • parameter and return type declarations where possible
  • delete unnecessary @param and @return annotations (but keep them if they do more than declare the type)
  • make protected methods & properties private where possible, and classes final where possible
@dbu dbu added this to the 3.0 milestone Dec 13, 2021
@dbu
Copy link
Member Author

dbu commented May 4, 2024

remaining issues fixed in #289

@dbu dbu closed this as completed May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@dbu