Add PHP-CS-Fixer #487
Merged
Add PHP-CS-Fixer #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jul 29, 2024
derrabus
approved these changes
Jul 29, 2024
.github/workflows/ci.yaml
Outdated
| uses: shivammathur/setup-php@v2 | ||
|
|
||
| with: | ||
| php-version: 8.1 |
There was a problem hiding this comment.
I just copied the highest PHP version, didn't notice 8.2 & 8.3 are missing, fixed.
HypeMC
force-pushed
the
add-cs-fixer
branch
2 times, most recently
from
681c5ec
to
5c78812
Compare
|
Thank you @HypeMC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo seems to be the only one that doesn't use PHP-CS-Fixer, which is a bit annoying when trying to contribute since I have to manually worry about coding standards. I'm not sure if there's a specific reason for that, so I decided to give it a try in this PR.
I took the
.php-cs-fixer.dist.phpfrom the framework repo and made a few adjustments. I removednullable_type_declarationandnullable_type_declaration_for_default_null_valuesince those are part of the standard Symfony set. Additionally, I setmodernize_strpostofalsesince the bundle still supports PHP >= 7.2.I'm not sure how to run it in the CI, as some repos use fabbot while others, like the MakerBundle, use GitHub Actions.
It would be best to hide whitespace changes while reviewing.