Skip to content

Commit

Permalink
feature #58335 [Notifier] deprecate the TransportFactoryTestCase (xab…
Browse files Browse the repository at this point in the history
…buh)

This PR was merged into the 7.2 branch.

Discussion
----------

[Notifier] deprecate the TransportFactoryTestCase

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | yes
| Issues        | Fix #54100
| License       | MIT

Commits
-------

c8b0fcc77b deprecate the TransportFactoryTestCase
  • Loading branch information
fabpot committed Sep 27, 2024
2 parents a5c2e68 + c35612c commit 148e4b8
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions Tests/SipgateTransportFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,13 @@
namespace Symfony\Component\Notifier\Bridge\Sipgate\Tests;

use Symfony\Component\Notifier\Bridge\Sipgate\SipgateTransportFactory;
use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
use Symfony\Component\Notifier\Test\IncompleteDsnTestTrait;

class SipgateTransportFactoryTest extends TransportFactoryTestCase
class SipgateTransportFactoryTest extends AbstractTransportFactoryTestCase
{
use IncompleteDsnTestTrait;

public function createFactory(): SipgateTransportFactory
{
return new SipgateTransportFactory();
Expand All @@ -40,4 +43,10 @@ public static function unsupportedSchemeProvider(): iterable
yield ['somethingElse://tokenId:token@host.test?senderId=s1'];
yield ['somethingElse://tokenId:token@host.test']; // missing senderId
}

public static function incompleteDsnProvider(): iterable
{
yield ['sipgate://:token@host.test?senderId=s1'];
yield ['sipgate://tokenId@host.test?senderId=s1'];
}
}

0 comments on commit 148e4b8

Please sign in to comment.