Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetNextMutualDependenciesReleaseWorker always updates minor version number #77

Open
andreaswolf opened this issue Nov 21, 2024 · 2 comments

Comments

@andreaswolf
Copy link

As the title says, even when performing a patchlevel (or major) release, the minor version number is always updated.

For a release of 0.4.1, this will lead to the dependencies being set to ^0.5 and the branch alias 0.5-dev, which is not always desirable, as long as you're not working on the next incompatible release.

For a release of 1.0, this will lead to the dependencies being set to ^1.1 and the branch alias 1.1-dev, which might also be wrong if you're creating a release branch for the 1.x series and want to continue developing 2.0 on main.

IMO it would be best to somehow be able to specify if and how the version should be raised (e.g. with a parameter with values "major"/"minor"/"unchanged").

@kayw-geek
Copy link
Collaborator

This seems like can be resole your issue.

@andreaswolf
Copy link
Author

Unfortunately not, because raising the minor version is hardcoded in VersionUtils.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants