allow setting patches file location through --patches-file option (fixes #25)
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not really sure what the issue with rector is, it wasn't working for me locally even before I made any changes either. If that's something I did wrong, please let me know. |
|
Rector in composer.json still on 0.18.3 Line 20 in 585e750 Could you try upgrade to ^1.2.5 ? Thank you. |
rmobis
force-pushed
the
feature/patches-file
branch
from
7c56344 to
2907192
Compare
samsonasik
reviewed
Sep 25, 2024
|
Please don't merge, I just noticed there's a bug. I'll fix it in a couple of hours when I back. |
|
Fixes have been applied, sorry for the delay. Let me know if there's anything else missing. |
samsonasik
reviewed
Sep 27, 2024
samsonasik
approved these changes
Sep 27, 2024
|
@TomasVotruba is anything missing for this to be merged? |
|
All good. Could you update the readme as well? |
Done |
|
Thank you 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--patches-fileoption which allows using a patches file instead of relying oncomposer.json.Since the structure for the
patches.jsonis "shallower" (noextraat the top) the code path is a bit different. Could have done a slightly bigger refactor, but I like to try and keep things simple when contributing to someone else's code.When
--patches-fileis set we assume this shallower format, meaning you can't call with--patches-file=composer.json. Could instead check the file name at runtime and decide what format to use, but this was simpler and I think it makes sense. Let me know what you think.Also add a test for changes.