fix(#187): truncate name at the last alphanumeric

so the resulting name is compliant with kubernetes convention

lib/objectutil/name.go

@@ -1,6 +1,8 @@
 package objectutil
 
 import (
+	"regexp"
+
 	"k8s.io/apimachinery/pkg/util/uuid"
 )
 
@@ -11,7 +13,15 @@ func GenerateObjectName(name string) string {
 		name = name[0 : maxNameLength-1]
 	}
 
+	for !isAlphanumeric(name[len(name)-1]) {
+		name = name[0 : len(name)-1]
+	}
+
 	id := uuid.NewUUID()
 
 	return name + "-" + string(id[0:5])
 }
+
+func isAlphanumeric(s byte) bool {
+	return regexp.MustCompile(`^[a-zA-Z0-9]*$`).MatchString(string(s))
+}

lib/objectutil/name_test.go

@@ -27,4 +27,12 @@ var _ = Describe("Name Utils", func() {
 			Expect(name).To(MatchRegexp(`^aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaab-\b\w{5}\b$`))
 		})
 	})
+
+	When("truncating the name would result in an invalid name", func() {
+		It("truncates it properly", func() {
+			longName := "kratix-promise-1.-@$#%&*()_+{}|:<>?/\\`~[]"
+			name := objectutil.GenerateObjectName(longName)
+			Expect(name).To(MatchRegexp(`^kratix-promise-1-\b\w{5}\b$`))
+		})
+	})
 })