Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thelio Mira B4-N3 (thelio-mira-b4-n3) #257

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Thelio Mira B4-N3 (thelio-mira-b4-n3) #257

merged 2 commits into from
Jul 10, 2024

Conversation

jacobgkau
Copy link
Member

@jacobgkau jacobgkau commented Jun 29, 2024

This adds the Thelio Mira B4-N3 (thelio-mira-b4-n3) to tech docs.

@jacobgkau jacobgkau force-pushed the mira-b4-n3 branch 10 times, most recently from 54a3ef0 to 2729ebc Compare July 8, 2024 09:59
@jacobgkau
Copy link
Member Author

I still need to update the GPU length clearance once I get those numbers. I also need to double-check the following items:

  • CPU fan model number (both front & back; I currently have them down as the same based on the CPU cooler manual)
  • Ethernet controller model number

Everything else should be ready to review.

@jacobgkau jacobgkau marked this pull request as ready for review July 8, 2024 19:33
@jacobgkau jacobgkau requested review from a team July 8, 2024 19:33
@jacobgkau
Copy link
Member Author

Updated the GPU clearance & confirmed the other two items were already correct.

@jacobgkau
Copy link
Member Author

Fixed the link on the homepage not working.

ahoneybun
ahoneybun previously approved these changes Jul 8, 2024
Copy link
Member

@ahoneybun ahoneybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little note and perhaps something to think about.

src/models/thelio-mira-b4-n3/repairs.md Outdated Show resolved Hide resolved
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small things, but otherwise looks great!

src/models/thelio-mira-b4-n3/README.md Outdated Show resolved Hide resolved
src/models/thelio-mira-b4-n3/internal-overview.md Outdated Show resolved Hide resolved
src/models/thelio-mira-b4-n3/internal-overview.md Outdated Show resolved Hide resolved
src/models/thelio-mira-b4-n3/repairs.md Outdated Show resolved Hide resolved
src/models/thelio-mira-b4-n3/repairs.md Outdated Show resolved Hide resolved
src/models/thelio-mira-b4-n3/repairs.md Outdated Show resolved Hide resolved
@jacobgkau
Copy link
Member Author

I've added a second commit to fix the Realtek RTL8125 link in the other sections that linked to it. Please use Rebase & Merge when merging this PR.

Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@leviport leviport merged commit bd5526e into master Jul 10, 2024
1 check passed
@leviport leviport deleted the mira-b4-n3 branch July 10, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants