Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about Fn+F4 for the 14" model and 16" model #258

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

ahoneybun
Copy link
Member

The darp10-b has the backlight set for Fn+F4 but we only note about the darp10 which has it on Fn+* due to the Numpad.

src/models/darp10/external-overview.md Outdated Show resolved Hide resolved
src/models/darp10/external-overview.md Outdated Show resolved Hide resolved
@ahoneybun ahoneybun force-pushed the backlight-darp10-b branch 2 times, most recently from 87de379 to b08878e Compare July 9, 2024 13:43
@ahoneybun
Copy link
Member Author

I think that is the best I can get with Markdown.

@ahoneybun ahoneybun requested a review from leviport July 9, 2024 13:43
leviport
leviport previously approved these changes Jul 9, 2024
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but let's make sure we get Jacob's blessing before we merge, just in case he prefers this be done a different way.

@leviport leviport requested a review from jacobgkau July 9, 2024 14:06
@jacobgkau
Copy link
Member

This is what you had:

screenshot-2024-07-11-22-28-42
screenshot-2024-07-11-22-28-47

Not optimal that the top asterisk and the meaning at the bottom can't be in view at the same time when maximized on a normal 1080p display. I'm updating it to look like this instead:

screenshot-2024-07-11-22-32-21
screenshot-2024-07-11-22-32-26

No scrolling, and matches how it's phrased on the rest of the page better. We could get away with just "14:" and "16:", but I think we might as well do the whole thing since the icons are taking up the vertical space anyway.

@leviport
Copy link
Member

I like that better as well!

leviport
leviport previously approved these changes Jul 11, 2024
Co-authored-by: Aaron Honeycutt <aaronhoneycutt@proton.me>
@jacobgkau jacobgkau requested review from leviport and a team July 11, 2024 22:46
@jacobgkau jacobgkau merged commit 8dd0049 into master Jul 11, 2024
1 check passed
@jacobgkau jacobgkau deleted the backlight-darp10-b branch July 11, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants