-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use centos as the base image #2
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,17 @@ | ||
steps: | ||
- uses: docker://docker:19.03.3 | ||
args: ['build', | ||
'--build-arg', 'OS_VERSION=$_OS_VERSION', | ||
'--build-arg', 'GIT_URL=$_GIT_URL', | ||
'--build-arg', 'GIT_REF=$_GIT_REF', | ||
'--tag', '$_IMG', | ||
'.' | ||
] | ||
args: ['build', | ||
'--build-arg', 'GIT_URL=https://github.com/uccross/skyhookdm-ceph', | ||
'--build-arg', 'GIT_REF=skyhook-luminous', | ||
'-t', 'jcnitdgp25/ceph-builder:skyhook-luminous-centos', | ||
'.' | ||
] | ||
|
||
- uses: docker://docker:19.03.3 | ||
runs: /bin/sh | ||
runs: ['/bin/sh'] | ||
secrets: [DOCKER_USERNAME, DOCKER_PASSWORD] | ||
args: | ||
- -c | ||
- | | ||
docker login -u $DOCKER_USERNAME -p $DOCKER_PASSWORD | ||
docker push $_IMG | ||
docker push jcnitdgp25/ceph-builder:skyhook-luminous-centos |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
#!/bin/bash | ||
set -ex | ||
|
||
# yum update -y | ||
yum install -y centos-release-scl scl-utils epel-release | ||
yum install -y git wget gnupg2 ccache | ||
yum install -y python-pip | ||
yum install -y devtoolset-8 devtoolset-7 | ||
# pip install --upgrade pip | ||
# pip install --upgrade virtualenv | ||
scl enable devtoolset-8 bash | ||
scl enable devtoolset-7 bash | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. all these packages should be installed already by the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It happend that these images were not installed by themselves and errored out due to their unavailabilty. So i installed them explicitly There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. so then we need to fix There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what I meant is that this script as a whole shouldn't be needed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh I see. Yeah thats the ideal. So, what should be done now ? Should we try to fix in the upstream or continue with patches like this ? Patching will be error prone though There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we need to remove this script. Building the image should work without it. If there's a problem when building the ceph-builder image after we remove this script, then it'll very likely be something on our end. The upstream script is used extensively by the ceph community, and has some minor tweaks for skyhook (install arrow/parquet). It could still be something on the upstream script, but it's unlikely |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for centos, apt-get cannot run. So we can remove this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah. missed it.