Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

Enhancement: Login Screen #417

Open
ashu-dadhich opened this issue Mar 9, 2017 · 7 comments
Open

Enhancement: Login Screen #417

ashu-dadhich opened this issue Mar 9, 2017 · 7 comments

Comments

@ashu-dadhich
Copy link

ashu-dadhich commented Mar 9, 2017

Summary
In the login screen the country chooser spinner should be filling the whole tab instead of just filling out just a portion of it which doesn't look good.
image
Plus the whole thing should be clickable not just the drop down icon. I personally had difficulty in clicking it.

@pragyach
Copy link

pragyach commented Mar 9, 2017

I am interested to solve this issue shall i go on? @sandarumk

@ashu-dadhich
Copy link
Author

@pragyach I have a solution in mind for it and It would be unproductive for both of us to pursue it.
Plus first let her approve it.

@rohands
Copy link

rohands commented Mar 10, 2017

@top-gun007 you can go ahead with this fix as it seems like a legit issue. However, please share your proposed solution here

@ashu-dadhich
Copy link
Author

@rohands I plan on doing the following:

  • make both the spinner and drop down clickable,

  • change the spinner width attribute to match parent and changing gravity of text to center.

  • Move the login button at the bottom of the screen as according to the current situation when the spinner expands it is drawn right over it which is not good.

@ashu-dadhich
Copy link
Author

Can I continue with this approach @rohands
Thank you

@ashu-dadhich
Copy link
Author

@sandarumk, @rohands can I continue?

@sandarumk
Copy link

yes go ahead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

4 participants