Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

CircleIntroActivity does not appear when you select Circle of Trust from the navigation bar #419

Open
Pooja-Mahadev-Soundalgekar opened this issue Mar 9, 2017 · 3 comments
Assignees

Comments

@Pooja-Mahadev-Soundalgekar

CircleIntroActivity is supposed to appear when the user selects "Circle of Trust" for the first time after installing the app. However, if the user selects "Circle of Trust" from the side navigation bar, this activity does not appear.

In the video below you can see that on selecting the navigation bar, CircleIntroActivity does not load but when you select Circle of Trust from the homepage, it detects it as the first time and launches CircleIntroActivity :
circleintro

@sandarumk Can I send a PR fixing this?

@rohands
Copy link

rohands commented Mar 10, 2017

What is your proposed solution?

@Pooja-Mahadev-Soundalgekar
Copy link
Author

Pooja-Mahadev-Soundalgekar commented Mar 11, 2017

@rohands When the user selects "Circle of trust" from the navigation bar we should check if intro has already been shown or not (In MainActivity.java line 117). "firstRun" is a variable stored in shared preferences so we can read this and this will tell us if intro has been run before or not. If its true, then we can load the CircleofTrustFragment and if it is false we can start the CircleIntroActivity. This is similar to what is done for the "Circle of trust" option in MainActivityFragment. (See MainActivityFragment.java lines 92 - 98).

@sandarumk
Copy link

You can go ahead with this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants