You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.
While solving issue #414 approved by @rohands, I realised the Navigation Bar logic is very inefficient and will require great modification. Soon I found there are many other bugs in it. These bugs including #414 are coming from #378 PR which had wrong solution. Some are listed below -
Multiple Instances still possible-
Just an example - Choose Safety Tools button on Main screen layout -> Choose Radar Button -> Go to Navigation bar and choose SafetyPlan -> Radar from there.....Multiple instances are created.
Orientation Change Problem -
Open Radar from Navigation Bar -> Change Orientation of your device -> Reopen Radar from Navigation Bar -> Reopen Radar from Navigation Bar-> Reopen Radar....multiple instances keeps on creating.
Multiple Exapanded groups in Navigation bar on orientation change -
For Ex - Navigation Bar -> Open Safety Tools -> Change Orientation -> Open Support Services
Safety Tools group should have collapsed but didn't.
If some group is expanded in Navigation Bar and navigation bar is closed -> On reopening navigation bar, group last opened remain expanded.
To solve #414 , I need to come back to old navigation bar logic. (PR #426 sent) @rohands@sandarumk Should I send PR with the correct solution for above issues. (On top of my PR #426)
The text was updated successfully, but these errors were encountered:
While solving issue #414 approved by @rohands, I realised the Navigation Bar logic is very inefficient and will require great modification. Soon I found there are many other bugs in it. These bugs including #414 are coming from #378 PR which had wrong solution. Some are listed below -
Multiple Instances still possible-
Just an example - Choose Safety Tools button on Main screen layout -> Choose Radar Button -> Go to Navigation bar and choose SafetyPlan -> Radar from there.....Multiple instances are created.
Orientation Change Problem -
Open Radar from Navigation Bar -> Change Orientation of your device -> Reopen Radar from Navigation Bar -> Reopen Radar from Navigation Bar-> Reopen Radar....multiple instances keeps on creating.
Multiple Exapanded groups in Navigation bar on orientation change -
For Ex - Navigation Bar -> Open Safety Tools -> Change Orientation -> Open Support Services
Safety Tools group should have collapsed but didn't.
To solve #414 , I need to come back to old navigation bar logic. (PR #426 sent)
@rohands @sandarumk Should I send PR with the correct solution for above issues. (On top of my PR #426)
The text was updated successfully, but these errors were encountered: