Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

Issue with sidebar in small screens #102

Closed
3 tasks
lunayach opened this issue Mar 12, 2018 · 4 comments
Closed
3 tasks

Issue with sidebar in small screens #102

lunayach opened this issue Mar 12, 2018 · 4 comments

Comments

@lunayach
Copy link
Member

Description

As a user,
I need to sometimes access the application on the small screen as well,
so that I can enjoy cross-platform functionality.

Mocks

After '/login' screen, I am redirected to '/menu' screen. In 'Navbar.component.ts', the initial state for navbar has been set to be 'out'. I think for small screen devices, this should be made 'in'.
rsz_respnsiveness

Acceptance Criteria

Update [Required]

  • Calling the toggle() method when say, (window.screen.width<512) returning true would animate that thing to state 'in'.

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

20 minutes

@Raxerz
Copy link

Raxerz commented Mar 12, 2018

@lunayach I think the fix for this issue can be covered as part #101 itself right?

@lunayach
Copy link
Member Author

lunayach commented Mar 12, 2018

Material Side Navbar comes built-in with this implementation. So yes, fixing #101 should also fix this. So, I'm creating PR for #101 👍

@Raxerz
Copy link

Raxerz commented Mar 12, 2018

Great. Go ahead and make the PR. This issue can be closed I suppose.

@Buddhiprabha
Copy link
Member

Duplicate.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants