Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

Material Module version updated with necessary changes in the files made. #104

Closed
wants to merge 1 commit into from

Conversation

ankita132
Copy link

@ankita132 ankita132 commented Mar 13, 2018

Description
In the newer versions of angular-cli the material module has deprecated.So it has to removed and necessary changes were required in the code.

Fixes #97 Replace the use of Material Module in Angular

Type of change
changes in package.json and some components.

@@ -1,4 +1,4 @@
<div class="col-md-12 text-center"><h2 class="stage-header">{{language?.menu.heading}}</h2></div>
<div class="col-md-5 pull-right"><h2 class="stage-header">{{language?.menu.heading}}</h2></div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't this change made in your previous PR?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.I will just drop the previous commit.

Copy link
Member

@paavininanda paavininanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think travis will detect the travis.yml file once you push some changes into this PR.

@@ -1,10 +1,10 @@
<div class="container-fluid">
<div class="sidebar" [@toggleNav]="state">
<md-toolbar color="primary">
<mat-toolbar color="primary">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve the merge conflicts in this file.

@shreyans29
Copy link

Hi @ankita132 , I have few concerns.

  1. Why is angular cli version updated. I doubt it will impact other components.
  2. We don't really need to change from a beta to compatibility mode. I mean, the beta is working if we use the right versions. If we are really upgrading then it must be actual upgrading. This feels like a workaround to me and may result in rework in future.

Now I get it might be huge task to upgrade it to latest version everywhere. In that case we can mark it as an issue to be worked on during GSoC period if not now.

Have a look at this. https://material.angular.io/guide/getting-started

Also take an update from the develop branch into your branch and travis will start passing then.

@ankita132
Copy link
Author

@shreyans29 what I think right now is that since the Material Module has deprecated so it is needed to get it upgraded to a newer version.Also all the necessary changes that should be done were done by simply using a tool.So I think there was no need to make it a GSOC issue.

@lunayach
Copy link
Member

Agree with you @shreyans29. I think using compatibility mode is a sort of temporary solution. We should upgrade to the official updated Material Package which would lead us to importing and exporting diif. material component individually unlike now when we are importing all the material components at once. As it may take time so it's better if it's taken up during the coding period.
Also @shreyans29 so do I need to solve the small screen issue #102 using the old material package or is it not needed.

@shreyans29
Copy link

@ankita132 Will you be working on this or can this be closed ?

@paavininanda
Copy link
Member

@ankita132 Are you working on this?

@ankita132
Copy link
Author

Sorry for the late reply. Actually we need a upgrade of only the material module so I guess this PR can be closed for now and a new PR can be sent for the same.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants