This repository has been archived by the owner on Nov 8, 2018. It is now read-only.
installed pytest dependency,added runner #367
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fenn-25 <fenn25.fn@gmail.com>
Monal5031
reviewed
Jul 10, 2018
| @@ -11,3 +11,4 @@ submit/ | |||
| *.DS_Store | |||
| */migrations/ | |||
| credentials.json | |||
| .pytest_cache | |||
There was a problem hiding this comment.
@fenn-cs, Not needed but you may wanna add .coverage* and coverage.xml to .gitignore as well.
Monal5031
reviewed
Jul 10, 2018
| @@ -0,0 +1,2 @@ | |||
| [pytest] | |||
| DJANGO_SETTINGS_MODULE = infohub.settings | |||
MehaKaushik
approved these changes
Jul 11, 2018
There was a problem hiding this comment.
Please address @Monal5031's comments. Everything else seems good.
|
Ok @sara-02 since this already has one approval I don't want to cancel it
by sending another commit.
I will rather add that in a in-progress PR and reference this.
…On 13 Jul 2018 7:17 a.m., "Sarah Masud" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .gitignore
<#367 (comment)>:
> @@ -11,3 +11,4 @@ submit/
*.DS_Store
*/migrations/
credentials.json
+.pytest_cache
@fenn-cs <https://github.com/Fenn-CS>, Not needed but you may wanna add
.coverage* and coverage.xml to .gitignore as well.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#367 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ANp4z-c7yyqMpJxe8O2CEvAo1erqjGMkks5uGDuRgaJpZM4VJz6S>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fenn-25 fenn25.fn@gmail.com
Description
Installed pytest and added test runner.
Fixes #363
Type of Change:
How Has This Been Tested?
Run locally
Checklist: