Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[civiremote_entity] Add support for files in forms #31

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

dontub
Copy link
Contributor

@dontub dontub commented Aug 5, 2024

This adds support for files in remote entity forms. It's a corresponding PR to systopia/de.systopia.remotetools#49. The URLs to download an existing file are not exposed to users, but CiviRemote acts as proxy to load a file. It's not yet possible to remove an existing file, but to replace it.

systopia-reference: 25860

@dontub dontub added enhancement New feature or request status:needs review Code needs review and testing labels Aug 5, 2024
@dontub dontub added this to the 1.1.x milestone Aug 5, 2024
@dontub dontub requested a review from jensschuppe August 5, 2024 09:58
@dontub dontub force-pushed the add-support-for-files branch 3 times, most recently from 3781a0e to 9147a12 Compare August 5, 2024 11:04
Copy link
Collaborator

@jensschuppe jensschuppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some documentation on the features and data flows (file contents, URLs) of how CiviRemote Entity handles file uploads in forms would be good.

modules/civiremote_entity/civiremote_entity.routing.yml Outdated Show resolved Hide resolved
Base automatically changed from add-support-for-case to 1.1.x August 9, 2024 12:58
@dontub dontub merged commit e848fcc into 1.1.x Aug 9, 2024
17 checks passed
@dontub dontub added status:fixed The issue has been resolved (usually by committing/merging code) and removed status:needs review Code needs review and testing labels Aug 9, 2024
@dontub dontub deleted the add-support-for-files branch August 9, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request status:fixed The issue has been resolved (usually by committing/merging code)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants