Use correct translation placeholder syntax for error messages #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensschuppe
added
bug
dontub
requested changes
Oct 1, 2024
There was a problem hiding this comment.
https://www.php-fig.org/psr/psr-3/ says:
Placeholder names MUST be delimited with a single opening brace
{and a single closing brace}. There MUST NOT be any whitespace between the delimiters and the placeholder name.
|
Well, there's a mix of two concepts here. First, Drupal's interface translation chimes in and replaces Drupal-style placeholders, before the message is being passed to the actual logger implementation, see https://drupalize.me/blog/how-log-messages-drupal-8 |
dontub
approved these changes
Oct 1, 2024
jensschuppe
added
status:fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LoggerInterfacemethod receives translatable strings and should therefor use the same placeholder syntax ast(). Translation template extraction will also complain about that.