xmlns:ns is now returned as attribute

[torokati44]

We're seeing a change of behavior starting with #545.

This causes CI on ruffle-rs/ruffle#13785 to fail: https://github.com/ruffle-rs/ruffle/actions/runs/6709470764/job/18232602777

The specific code that's broken:

var y1 = <y xmlns:ns="foo" a="10" ns:c="30" ns:d="40"/>;
trace(y1.@*);

Expected: 103040
Ruffle with quick-xml update: foo103040

It seems the xmlns:ns attribute is now returned when it previously wasn't.
Is this expected? If so, could you assist us in how to get back the old behavior?

[Mingun]

Could you explain, what that syntax mean and should do?

var y1 = <y xmlns:ns="foo" a="10" ns:c="30" ns:d="40"/>;
trace(y1.@*);

[torokati44]

Yes, sorry, this was not evident at all... 😅

This is ActionScript - the programming language for Adobe Flash movies.

This test is supposed to list all the attribute values of the element.
An excerpt from the documentation:

You can use the * wildcard symbol with the @ symbol to access all attributes of an XML or XMLList object, as in the following code:

var employee:XML =  
    <employee id="6401" code="233"> 
        <lastName>Wu</lastName> 
        <firstName>Erin</firstName> 
    </employee>; 
trace(employee.@*.toXMLString());  
// 6401 
// 233

https://help.adobe.com/en_US/as3/dev/WS5b3ccc516d4fbf351e63e3d118a9b90204-7e6b.html#WS5b3ccc516d4fbf351e63e3d118a9b90204-7e61

[torokati44]

As for how quick-xml is used, I think this is a good place to start looking around: https://github.com/ruffle-rs/ruffle/blob/master/core/src/avm2/e4x.rs

[Dinnerbone]

I looked into this on the Ruffle side, it's our mistake, sorry!

We expected to see xmlns and xml as ResolveResult::Unknown("xmlns")/ResolveResult::Unknown("xml") - so the change to resolve them out to their URLs threw us off.

[torokati44]

Turns out, this was on us. Sorry for bothering you and wasting your bandwidth... 😞