Hide quick_xml::escape::resolve_html5_entity under escape-html feature again
#764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature again This function has significant influence to the compilation time (10+ seconds or 5x times)
|
In the future, we could consider to use phf_codegen crate to generate effective function (together with getting up-to-date mapping from WhatWG site). |
dralley
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function has significant influence to the compilation time (10+ seconds or 5x times)
Closes #763
Maybe it can be solved without hiding function under feature flag, but that is not in my priority list. If someone wants to investigate this issue, they can do PR 😄