Convert some unit tests to integration tests #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…check if we need more events for text Thus, now checking for types of events that relate to the "text" is done in one place, and not in two (Review in whitespace changes ignored mode)
Those tests does not depend on the internals, so can be tested outside. This will reduce the size of pack on crates.io
Mingun
force-pushed
the
move-to-integration
branch
from
a571cb7
to
a24ed89
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #767 +/- ##
==========================================
- Coverage 61.81% 60.22% -1.60%
==========================================
Files 41 41
Lines 16798 16191 -607
==========================================
- Hits 10384 9751 -633
- Misses 6414 6440 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because unit tests located inside the source files, their are packed in release pack, but integration tests are excluded. By moving tests size of pack is reduced and crate should compile slightly faster because there are less code to process.
Also this PR includes some small refactoring in deserializer which makes code slightly simpler to understand (in prepare to #766).