Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert some unit tests to integration tests #767

Merged
merged 6 commits into from
Jun 23, 2024
Merged

Convert some unit tests to integration tests #767

merged 6 commits into from
Jun 23, 2024

Commits on Jun 23, 2024

  1. Add sanity checks that buffers contains expected data in emit_band … 

    …and `emit_end`
    @Mingun
    Mingun committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    00e3258 View commit details
    Browse the repository at this point in the history

  2. Rename need_trim_end to current_event_is_last_text and use it to … 

    …check if we need more events for text

Thus, now checking for types of events that relate to the "text" is done in one place, and not in two

(Review in whitespace changes ignored mode)
    @Mingun
    Mingun committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    9de838f View commit details
    Browse the repository at this point in the history

  3. Inline Deserializer::next_text

    @Mingun
    Mingun committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    a53e77a View commit details
    Browse the repository at this point in the history

  4. Move small buffers tests from unit tests to integration tests 

    Those tests does not depend on the internals, so can be tested outside.
This will reduce the size of pack on crates.io
    @Mingun
    Mingun committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    a00a996 View commit details
    Browse the repository at this point in the history

  5. Move encoding integration tests to tests/encodings.rs

    @Mingun
    Mingun committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    8c75ecd View commit details
    Browse the repository at this point in the history

  6. Move writer integration tests for indentation to tests/writer-indenta… 

    …tion.rs
    @Mingun
    Mingun committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    a24ed89 View commit details
    Browse the repository at this point in the history