Skip to content

Commit

Permalink
Emit internal signers after unlocking in internal signers
Browse files Browse the repository at this point in the history
This ensures that by the time internal signers hit the redux store, the
internal signers are known to be unlocked. This is useful because the
store ignores emitted signers while the signers are known to be locked,
to avoid clearing the signers list at lock time (which emits an empty
list of working signers for any services that are relying on that list
to know what can currently be actively signed).
  • Loading branch information
Shadowfiend committed Jul 20, 2023
1 parent 449b053 commit 7543954
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions background/services/internal-signer/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -334,8 +334,6 @@ export default class InternalSignerService extends BaseService<Events> {
this.#hiddenAccounts = {
...plainTextVault.hiddenAccounts,
}

this.#emitInternalSigners()
}
}

Expand All @@ -347,6 +345,8 @@ export default class InternalSignerService extends BaseService<Events> {
}

this.#unlock()
this.#emitInternalSigners()

return true
}

Expand Down

0 comments on commit 7543954

Please sign in to comment.