Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password strength bar #1329

Closed
mhluongo opened this issue Apr 18, 2022 · 3 comments · Fixed by #1594 or #1732
Closed

Password strength bar #1329

mhluongo opened this issue Apr 18, 2022 · 3 comments · Fixed by #1594 or #1732
Assignees
@jagodarybacka
Labels
Type: Security Security-related concerns & enhancements

Comments

@mhluongo
Copy link
Contributor

Using a robust pattern-based tool like https://github.com/dropbox/zxcvbn. Combined with #1328, we'll have a strong mitigation for cracking encrypted wallets.
@mhluongo mhluongo added the Type: Security Security-related concerns & enhancements label Apr 18, 2022
@henryboldi
Copy link
Contributor

Darn it
password

@0xDaedalus 0xDaedalus mentioned this issue Apr 28, 2022
Closed
41 tasks
@0xDaedalus 0xDaedalus self-assigned this Jun 6, 2022
@0xDaedalus 0xDaedalus mentioned this issue Jun 8, 2022
Merged
@greg-nagy greg-nagy reopened this Jun 15, 2022
@greg-nagy
Copy link
Contributor

greg-nagy commented Jun 17, 2022 •
edited by VladUXUI
Loading

Discussion thread

Show 1 value for “time to crack” with an (i) I guess to state our assumptions
Show “score” 1/4 as WEAK (1-2), GOOD (3), STRONG(4)
If the user tried to move ahead with the WEAK password, just have it waggle or pulse as feedback

Common understanding

  • No hard requirements
  • passwrod strength bar
  • messaging/tooltip on how to select a strong password

Figma link
https://www.figma.com/file/q8gfu9XTbYBF07KMnDCtsD/UI---Dark?node-id=11460%3A207541

CleanShot 2022-06-22 at 09 44 32

@greg-nagy greg-nagy mentioned this issue Jun 17, 2022
Merged
@0xDaedalus 0xDaedalus removed their assignment Jun 17, 2022
@greg-nagy
Copy link
Contributor

greg-nagy commented Jun 21, 2022 •
edited by VladUXUI
Loading

The scope of this issue for Sprint 9 is to make a product decision about what to implement.

Updated the above comment with the final product decision and design (+figma link)

@greg-nagy greg-nagy added the Status: Blocked Blocked by another issue! label Jun 21, 2022
@greg-nagy greg-nagy removed Status: Blocked Blocked by another issue! Passed QA labels Jun 22, 2022
@greg-nagy greg-nagy changed the title Enforce minimum password strength Password strength bar Jun 22, 2022
@jagodarybacka jagodarybacka self-assigned this Jul 4, 2022
@jagodarybacka jagodarybacka mentioned this issue Jul 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jagodarybacka jagodarybacka

Labels
Type: Security Security-related concerns & enhancements
Projects
None yet
Milestone
No milestone
7 participants
@mhluongo @henryboldi @puppycodes @greg-nagy @jagodarybacka @0xDaedalus @SJQuality