Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinguish assets through home network #2709

Open
3 tasks
kkosiorowska opened this issue Dec 2, 2022 · 0 comments
Open
3 tasks

Distinguish assets through home network #2709

kkosiorowska opened this issue Dec 2, 2022 · 0 comments
Labels
Type: Enhancement New feature or request

Comments

@kkosiorowska
Copy link
Contributor

kkosiorowska commented Dec 2, 2022 •
edited
Loading

Description

Currently, we don't distinguish assets through the homeNetwork. As a result, there are problems in displaying asset balances. Please check the problem that occurred for BSC.

Requirements

  • tokens with the same symbol and contract code on different networks are different assets
  • tokens bridged across multiple networks (like USDC) are different assets even though they represent the same underlying
  • therefore - an asset can only belong to one network - and must have a homeNetwork.

Expectations

  • Make homeNetwork a required attribute on AnyAsset.
  • Update Portfolio page. Make sure how we want to present this view by displaying the sum of similar asset balances.
  • Update existing logic. Some of the selectors should distinguish the network for assets for example selectAssetPricePoint.
@kkosiorowska kkosiorowska added the Type: Enhancement New feature or request label Dec 2, 2022
@kkosiorowska kkosiorowska mentioned this issue Dec 2, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kkosiorowska