Disable password strength check #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought we wanted to put this behind feature flag 🤔 |
|
I think since its 10 lines of code there is not really much worth to adding a feature flag here - once we have a design and way forward we can start iterating on it with a feature flag |
henryboldi
reviewed
Jun 14, 2022
| @@ -5,7 +5,6 @@ import { | |||
| selectDefaultWallet, | |||
| } from "@tallyho/tally-background/redux-slices/ui" | |||
| import { useHistory } from "react-router-dom" | |||
| import zxcvbn from "zxcvbn" | |||
There was a problem hiding this comment.
Remove it from package.json too or nah?
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily disables password strength check while we figure out desired UX
Ref #1329