Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NFTs support for BSC #2716

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Add NFTs support for BSC #2716

merged 2 commits into from
Dec 6, 2022

Conversation

kkosiorowska
Copy link
Contributor

@kkosiorowska kkosiorowska commented Dec 5, 2022

Closes #2570
Refs #2569

This PR adds NFTs support for Binance Smart Chain. Uses NFT API from simplehash.

UI

Screenshot 2022-12-05 at 13 21 24

To Test

Set SUPPORT_BINANCE_SMART_CHAIN to true.

  • check NFTs support

Latest build: extension-builds-2716 (as of Tue, 06 Dec 2022 08:58:55 GMT).

@kkosiorowska kkosiorowska marked this pull request as ready for review December 6, 2022 09:01
Copy link
Contributor

@hyphenized hyphenized left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -5,13 +5,15 @@ import { HexString } from "../types"
import logger from "./logger"
import { sameEVMAddress } from "./utils"

type SupportedChain = "polygon" | "arbitrum" | "optimism" | "ethereum" | "bsc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@hyphenized hyphenized merged commit 81d4487 into main Dec 6, 2022
@hyphenized hyphenized deleted the bsc-support-NFTs branch December 6, 2022 09:18
@greg-nagy greg-nagy mentioned this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support NFTs on Binance Smart Chain
2 participants