Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to a given network if adding a network that is already added. #3154

Merged
merged 6 commits into from
Jul 10, 2023

Commits on Mar 14, 2023

  1. Switch to a given network if adding a network that is already added.

    Since a given dapp does not necessarily have a sense of what networks are supported within the wallet (and since some dapps rely exclusively on wallet_addEthereumChain) we should support the functionality of switching to a network when receiving a wallet_addEthereumChain message with a chainID that we already support.
    0xDaedalus committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    7a34024 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Configuration menu
    Copy the full SHA
    6c2acec View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. Configuration menu
    Copy the full SHA
    5469aec View commit details
    Browse the repository at this point in the history
  2. Fix concurrency error in provider bridge test

    The new check for whether a new custom network already exists changes
    timing that was expected to be static. The relevant assertions are now
    wrapped in retries that will wait a certain amount of time for the given
    assertion to pass.
    Shadowfiend committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    5e8bc26 View commit details
    Browse the repository at this point in the history
  3. Fix switching networks when adding an existing network

    This fix is the result of adding a test to confirm a popup is not shown.
    Notably, the behavior of switching the network silently requires extra
    vetting; however, this commit implements it as that was the branch's
    intent.
    Shadowfiend committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    af041d6 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Configuration menu
    Copy the full SHA
    0ebefb5 View commit details
    Browse the repository at this point in the history