Refactor prices caching #3526
Merged
Refactor prices caching #3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
9 tasks
| @@ -60,7 +48,6 @@ const assetsSlice = createSlice({ | |||
| mappedAssets[newAsset.symbol] = [ | |||
| { | |||
| ...newAsset, | |||
There was a problem hiding this comment.
do we need to spread that newAsset?
There was a problem hiding this comment.
Not really, but this has helped me spot a different bottleneck. Thanks!
Reducing the amount of updates we make to the assets slice should improve performance and reduce blocking UI due to store updates. The new prices slice indexes asset prices by asset ids, this way each update is diffed and processed faster.
The now available isTrustedToken checks if assets meet these replaced conditions, isTokenListAsset/isNetworkBaseAsset.
Comment on lines
390
to
391
| | (SmartContractFungibleAsset & { tokenLists: string[] }) | ||
| | (SmartContractFungibleAsset & { verified: true }) { |
There was a problem hiding this comment.
tokenLists and verified should be at the metadata level.
This should help reduce redundancy after trust checks
Removed symbols from network base asset ids generation, added chain id to ids for all asset types. This allows us to use these for indexing assets across networks in e.g. redux.
kkosiorowska
previously approved these changes
Jul 26, 2023
|
@kkosiorowska looking at the outstanding comments, I'd say unless you have a clear signal that @hyphenized wants to act on any of it tomorrow morning, we land this as-is and use it to cut a small release that can go through the testing paces. |
These were overlooked during the process of segregating prices from the assets slice
Merged
jagodarybacka
added a commit
that referenced
this pull request
Aug 2, 2023
## What's Changed * v0.43.3 by @hyphenized in #3570 * Use JSON onboarding in e2e tests of transactions by @michalinacienciala in #3559 * Refactor prices caching by @hyphenized in #3526 * Fix assertions made on the latest transaction by @michalinacienciala in #3573 **Full Changelog**: v0.43.3...v0.44.0 Latest build: [extension-builds-3577](https://github.com/tahowallet/extension/suites/14645396551/artifacts/830824018) (as of Fri, 28 Jul 2023 14:43:48 GMT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relocates cached asset prices to a new redux slice. This reduces performance hits after price fetching by avoiding nested array diffs, which Immer struggles to manage. Consequently, it prevents unnecessary updates being serialized/deserialized.
To Test
This clears cached data for both account balances and assets, after switching from
mainto this branch:Latest build: extension-builds-3526 (as of Thu, 27 Jul 2023 06:33:36 GMT).