Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not open uninstall URL on development builds #3557

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Conversation

hyphenized
Copy link
Contributor

@hyphenized hyphenized commented Jul 19, 2023

This is probably creating a bunch of false positives on posthog

Latest build: extension-builds-3557 (as of Thu, 20 Jul 2023 01:51:17 GMT).

@hyphenized hyphenized requested a review from a team July 19, 2023 04:02
@jagodarybacka
Copy link
Contributor

false positives

I don't think so as dev builds should be using DEV library (or how is it called on posthog) so we should be able to filter them, right? If not then probably we should do something about it on the posthog side as this is affecting other events as well.

But tbh I'm glad to avoid closing that window every time so 👍

@hyphenized
Copy link
Contributor Author

false positives

I don't think so as dev builds should be using DEV library (or how is it called on posthog) so we should be able to filter them, right? If not then probably we should do something about it on the posthog side as this is affecting other events as well.

But tbh I'm glad to avoid closing that window every time so 👍

That's true but we're opening the uninstall url for production, so the uuid passed is sent in an event with production parameters.

Copy link
Contributor

@Shadowfiend Shadowfiend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to have some sort of tweak to the URL to report it in dev mode, mostly so we can check that the website side of things is working as expected, but it's a small change and we might as well get on with it heh.

@Shadowfiend Shadowfiend merged commit fde86ec into main Jul 20, 2023
6 checks passed
@Shadowfiend Shadowfiend deleted the not-a-real-user branch July 20, 2023 01:46
@jagodarybacka jagodarybacka mentioned this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants