Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buggity fixes: two small bug fixes #3558

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Buggity fixes: two small bug fixes #3558

merged 3 commits into from
Jul 20, 2023

Commits on Jul 20, 2023

  1. Fix errors with price oracles on unsupported chains 

    On these chains, the code attempted to interact with an undefined
spot oracle key, which meant the price lookup failed. Unfortunately due
to the way lookups are batched, this meant that adding a network with
assets that did not have a spot price oracle defined killed all price
lookups.
    @Shadowfiend
    Shadowfiend committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    449b053 View commit details
    Browse the repository at this point in the history

  2. Emit internal signers after unlocking in internal signers 

    This ensures that by the time internal signers hit the redux store, the
internal signers are known to be unlocked. This is useful because the
store ignores emitted signers while the signers are known to be locked,
to avoid clearing the signers list at lock time (which emits an empty
list of working signers for any services that are relying on that list
to know what can currently be actively signed).
    @Shadowfiend
    Shadowfiend committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    7543954 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into buggity-fixes

    @jagodarybacka
    jagodarybacka authored Jul 20, 2023
    Configuration menu
    Copy the full SHA
    f0a49fc View commit details
    Browse the repository at this point in the history