-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use JSON onboarding in e2e tests of transactions #3559
Commits on Jul 20, 2023
-
Use JSON onboarding in e2e tests of transactions
Prior to this change we were onbording using a seed phrase, which was not ideal, as it could lead to a seed phrase leakage in the Playwright report added to the artifacts of CI jobs (that's why we've temporarily switched off storing of the test artifacts). Now that we support in Taho the onboarding with a JSON keystore file (which stores an encrypted private key), we are good to use this method of account import in our E2E tests. This method is safer, as the sensitive data entered in the form during onboarding is obfuscated, so there's no risk it will leak in the Playwright report (and even if so, what will leak will be just a password, not a corresponding to it JSON file). As we're switching to this onboarding method, we can bring back storing of the Playwrigt reports in the CI jobs artifacts. Apart from the above, as part of this commit/PR we're also introducing a script which can be used to generate a JSON keystore file based on the provided private key and password.
Configuration menu - View commit details
-
Copy full SHA for f13d2da - Browse repository at this point
Copy the full SHA f13d2daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 513bce5 - Browse repository at this point
Copy the full SHA 513bce5View commit details
Commits on Jul 21, 2023
-
Run
yarn install
in thescripts/key-generation
folder before lintingWe need to run the install there to avoid complaints from the linter about a missing module (`Unable to resolve path to module 'ethereumjs-wallet'`).
Configuration menu - View commit details
-
Copy full SHA for 24b20bc - Browse repository at this point
Copy the full SHA 24b20bcView commit details -
Change name of the variables storing JSON body & password
The transactions e2e tests use the first address of the testing wallet (`testertesting.eth`). But we already know that in some tests that we plan to add in the future, we'll want to use a different account - the third address of the testing wallet (`e2e.testertesting.eth`). So we will need to use names of the variables and secrets that differenciate those different addresses.
Configuration menu - View commit details
-
Copy full SHA for 4a59635 - Browse repository at this point
Copy the full SHA 4a59635View commit details -
Uncomment code sending transaction
I've pushed by mistake a change commenting out some fragment of the e2e tests that shouldn't be commented out. I'm fixing it in this commit.
Configuration menu - View commit details
-
Copy full SHA for 2229425 - Browse repository at this point
Copy the full SHA 2229425View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e22845 - Browse repository at this point
Copy the full SHA 3e22845View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1cce0db - Browse repository at this point
Copy the full SHA 1cce0dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3f274c - Browse repository at this point
Copy the full SHA c3f274cView commit details
Commits on Jul 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4693c0f - Browse repository at this point
Copy the full SHA 4693c0fView commit details -
Give dev fork builds the -fork suffix
We changed this for production fork builds to differentiate from the release builds, and we updated e2e tests to look for the suffix, but on non release branches the fork builds were not getting the suffix, leading to test failures.
Configuration menu - View commit details
-
Copy full SHA for faa9b99 - Browse repository at this point
Copy the full SHA faa9b99View commit details
Commits on Jul 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 60f56b5 - Browse repository at this point
Copy the full SHA 60f56b5View commit details
Commits on Jul 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6a1cc7f - Browse repository at this point
Copy the full SHA 6a1cc7fView commit details