Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JSON onboarding in e2e tests of transactions #3559

Merged
merged 12 commits into from
Jul 25, 2023
Merged

Commits on Jul 20, 2023

  1. Use JSON onboarding in e2e tests of transactions

    Prior to this change we were onbording using a seed phrase, which was not ideal,
    as it could lead to a seed phrase leakage in the Playwright report added to the
    artifacts of CI jobs (that's why we've temporarily switched off storing of the
    test artifacts).
    Now that we support in Taho the onboarding with a JSON keystore file (which
    stores an encrypted private key), we are good to use this method of account
    import in our E2E tests. This method is safer, as the sensitive data entered in
    the form during onboarding is obfuscated, so there's no risk it will leak in the
    Playwright report (and even if so, what will leak will be just a password, not a
    corresponding to it JSON file).
    As we're switching to this onboarding method, we can bring back storing of the
    Playwrigt reports in the CI jobs artifacts.
    
    Apart from the above, as part of this commit/PR we're also introducing a script
    which can be used to generate a JSON keystore file based on the provided private
    key and password.
    michalinacienciala committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    f13d2da View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    513bce5 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Run yarn install in the scripts/key-generation folder before linting

    We need to run the install there to avoid complaints from the linter about a
    missing module (`Unable to resolve path to module 'ethereumjs-wallet'`).
    michalinacienciala committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    24b20bc View commit details
    Browse the repository at this point in the history
  2. Change name of the variables storing JSON body & password

    The transactions e2e tests use the first address of the testing wallet
    (`testertesting.eth`). But we already know that in some tests that we plan to
    add in the future, we'll want to use a different account - the third address of
    the testing wallet (`e2e.testertesting.eth`). So we will need to use names of
    the variables and secrets that differenciate those different addresses.
    michalinacienciala committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    4a59635 View commit details
    Browse the repository at this point in the history
  3. Uncomment code sending transaction

    I've pushed by mistake a change commenting out some fragment of the e2e tests
    that shouldn't be commented out. I'm fixing it in this commit.
    michalinacienciala committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    2229425 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3e22845 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1cce0db View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c3f274c View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2023

  1. Configuration menu
    Copy the full SHA
    4693c0f View commit details
    Browse the repository at this point in the history
  2. Give dev fork builds the -fork suffix

    We changed this for production fork builds to differentiate from the release builds, and we updated e2e tests to look for the suffix, but on non release branches the fork builds were not getting the suffix, leading to test failures.
    Shadowfiend authored Jul 22, 2023
    Configuration menu
    Copy the full SHA
    faa9b99 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Configuration menu
    Copy the full SHA
    60f56b5 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Configuration menu
    Copy the full SHA
    6a1cc7f View commit details
    Browse the repository at this point in the history