Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.43.0 #3560

Merged
merged 4 commits into from
Jul 23, 2023
Merged

v0.43.0 #3560

merged 4 commits into from
Jul 23, 2023

Conversation

jagodarybacka
Copy link
Contributor

@jagodarybacka jagodarybacka commented Jul 20, 2023 •
edited by github-actions bot
Loading

What's Changed

Full Changelog: v0.42.0...v0.43.0

Latest build: extension-builds-3560 (as of Sun, 23 Jul 2023 22:56:32 GMT).

@github-actions
Copy link

github-actions bot commented Jul 20, 2023 •
edited by SJQuality
Loading

Release checklist

This release checklist should be performed before release is published.

  • dev tests should be performed by the dev team
  • if something is not working please create an issue and link it here. Checkbox should be checked only if everything was fine
  • in case of serious issues or doubts you should ask the team first

Don't forget to approve the PR when checklist is finished ✅

Dev tests

🚀 Version update

  • update from previous version with some accounts loaded

Manual tests

📨 Add account

  1. Add read-only account with ENS
    • check assets
    • check balance
    • check NFTs
    • check abilities (abilities should not be displayed)
    • check activities
    • check overview page
  2. Add read-only account with UNS
    • check assets
    • check balance
    • check NFTs
    • check abilities (abilities should not be displayed)
    • check activities
    • check overview page
  3. Add read-only account with 0x address
    • check assets
    • check balance
    • check NFTs
    • check abilities (abilities should not be displayed)
    • check activities
    • check overview page
  4. Import account with a seed phrase
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check overview page
    • check seed phrase export
    • check private key export for first account
  5. Add another account from the same seed phrase
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check overview page
    • check private key export for second account
  6. Add account with a Ledger
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check overview page
  7. Create new wallet
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check overview page
    • check private key export
  8. Add account with private key
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check overview page
    • check private key export
  9. Add account with JSON keystore
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check overview page
    • check private key export

🗑️ Remove account

  1. Remove account by type
    • remove read-only account
    • remove address from imported account
    • remove Ledger account
    • remove account imported with private key
    • remove account imported with JSON keystore
    • remove selected account
    • remove not selected account
    • remove all accounts
  2. Remove account and check functinalities
    • add removed address from imported account
    • remove all addresses from imported account
    • check if NFTs are removed for removed accounts
    • check if abilities are removed for removed accounts
    • check if Portfolio page is updated for removed accounts

💌 Send base asset

  1. Ethereum mainnet
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  2. Polygon
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain
    • check gas settings and gas price
    • sign
    • check transaction on scan website

🎁 Send ERC20

  1. Ethereum mainnet
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  2. Polygon
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain
    • check gas settings and gas price
    • sign
    • check transaction on scan website

💸 Internal swap

  1. Ethereum mainnet
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  2. Polygon
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website

📡 dApps connections

🎭 Sign in with Ethereum

🐶 Default wallet

  1. Default wallet setting turned OFF
    • connect with dapp without MM available using Taho
    • connect with dapp with MM available using MM
  2. Default wallet setting turnef ON
    • connect with dapp without MM available using Taho
    • connect with dapp with MM available using Taho

⚙️ Settings

  • check hide balance under $2 option
  • check bug reports - export logs
  • check connected dapp - confirm you are able to disconnect from a dapp

☀️ Abilities

  • check each filter option
  • delete ability
  • mark ability as completed

🌠 NFTs page

  1. NFTs page
    • browse NFTs
    • expand and collapse collection
    • check NFT preview
    • check Badges tab
  2. NFTs filters
    • check each sort type
    • disable account
    • disable collection

@jagodarybacka
Copy link
Contributor Author

jagodarybacka commented Jul 20, 2023 •
edited by andreachapman
Loading

@andreachapman's Release checklist

This release checklist should be performed before release is published.

  • dev tests should be performed by the dev team
  • if something is not working please create an issue and link it here. Checkbox should be checked only if everything was fine
  • in case of serious issues or doubts you should ask the team first

Don't forget to approve the PR when checklist is finished ✅

Dev tests

🚀 Version update

  • update from previous version with some accounts loaded

Manual tests

📨 Add account

  1. Add read-only account with ENS
    • check assets
    • check balance
    • check NFTs
    • check abilities (abilities should not be displayed)
    • check activities
    • check overview page
  2. Add read-only account with UNS
    • check assets
    • check balance
    • check NFTs
    • check abilities (abilities should not be displayed)
    • check activities
    • check overview page
  3. Add read-only account with 0x address
    • check assets
    • check balance
    • check NFTs
    • check abilities (abilities should not be displayed)
    • check activities
    • check overview page
  4. Import account with a seed phrase
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check overview page
    • check seed phrase export
    • check private key export for first account
  5. Add another account from the same seed phrase
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check overview page
    • check private key export for second account
  6. Add account with a Ledger
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check overview page
  7. Create new wallet
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check overview page
    • check private key export
  8. Add account with private key
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check overview page
    • check private key export
  9. Add account with JSON keystore
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check overview page
    • check private key export

🗑️ Remove account

  1. Remove account by type
    • remove read-only account
    • remove address from imported account
    • remove Ledger account
    • remove account imported with private key
    • remove account imported with JSON keystore
    • remove selected account
    • remove not selected account
    • remove all accounts
  2. Remove account and check functinalities
    • add removed address from imported account
    • remove all addresses from imported account
    • check if NFTs are removed for removed accounts
    • check if abilities are removed for removed accounts
    • check if Portfolio page is updated for removed accounts

💌 Send base asset

  1. Ethereum mainnet
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  2. Polygon
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain
    • check gas settings and gas price
    • sign
    • check transaction on scan website

🎁 Send ERC20

  1. Ethereum mainnet
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  2. Polygon
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • [x ] check gas settings and gas price
    • [x ] sign
    • [ x] check transaction on scan website
  5. Avalanche
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain
    • check gas settings and gas price
    • sign
    • check transaction on scan website

💸 Internal swap

  1. Ethereum mainnet
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  2. Polygon
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website

📡 dApps connections

🎭 Sign in with Ethereum

🐶 Default wallet

  1. Default wallet setting turned OFF
    • connect with dapp without MM available using Taho
    • connect with dapp with MM available using MM
  2. Default wallet setting turnef ON
    • connect with dapp without MM available using Taho
    • connect with dapp with MM available using Taho

⚙️ Settings

  • check hide balance under $2 option
  • check bug reports - export logs
  • check connected dapp - confirm you are able to disconnect from a dapp

☀️ Abilities

  • check each filter option
  • delete ability
  • mark ability as completed

🌠 NFTs page

  1. NFTs page
    • browse NFTs
    • expand and collapse collection
    • check NFT preview
    • check Badges tab
  2. NFTs filters
    • check each sort type
    • disable account
    • disable collection

hyphenized and others added 2 commits July 20, 2023 11:50
@hyphenized
Add bigint filter for jsondiffpatch
fd8c798 
In the current implementation, bigints are treated as objects and are
incorrectly excluded from patches. This fixes bigint diffing by adding
a handler for these cases to the jsondiffpatch pipeline.
@Shadowfiend
Add bigint filter for jsondiffpatch (#3561)
6a220e1 
In the current implementation, `bigints` are treated as objects and are
incorrectly excluded from generated patches. This fixes `bigint` diffing
by adding a handler for these cases to the `jsondiffpatch` pipeline.

## To Test
- [x] Send assets
- [x] Check that balance changes after transaction succeeds

Latest build:
[extension-builds-3561](https://github.com/tahowallet/extension/suites/14449081920/artifacts/815732866)
(as of Thu, 20 Jul 2023 17:02:04 GMT).
@hyphenized hyphenized mentioned this pull request Jul 21, 2023
Merged
@hyphenized hyphenized merged commit 2dea1ca into main Jul 23, 2023
6 checks passed
@hyphenized hyphenized deleted the release-0.43.0 branch July 23, 2023 22:51
@hyphenized hyphenized mentioned this pull request Jul 24, 2023
Merged
Shadowfiend added a commit that referenced this pull request Jul 24, 2023
@Shadowfiend
v0.43.1 (#3563)
bf21428 
## What's Changed
* v0.43.0 by @jagodarybacka in
#3560
* Add bigint filter for jsondiffpatch by @hyphenized in
#3561

**Full Changelog**:
v0.43.0...v0.43.1

Latest build:
[extension-builds-3563](https://github.com/tahowallet/extension/suites/14505054594/artifacts/820084348)
(as of Sun, 23 Jul 2023 23:02:24 GMT).
Shadowfiend added a commit that referenced this pull request Jul 24, 2023
@Shadowfiend
v0.43.2 (#3566)
7f720c4 
## What's Changed
* Fix incorrect build asset uploaded on release by @hyphenized in
#3564
* Add dev 0x API key to dev build by @Shadowfiend in
#3565
* v0.43.1 by @hyphenized in
#3563
* v0.43.0 by @jagodarybacka in
#3560


**Full Changelog**:
v0.43.0...v0.43.2

Latest build:
[extension-builds-3566](https://github.com/tahowallet/extension/suites/14509660502/artifacts/820470537)
(as of Mon, 24 Jul 2023 06:00:13 GMT).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyphenized hyphenized hyphenized approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jagodarybacka @hyphenized @Shadowfiend