-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing e2e #3567
Fix failing e2e #3567
Conversation
The variable is needed by the `e2e-tests/regular/transactions.spec.ts` test.
We changed this for production fork builds to differentiate from the release builds, and we updated e2e tests to look for the suffix, but on non release branches the fork builds were not getting the suffix, leading to test failures.
It's likely that the two remaining problems will be fixed by #3569. I merged this change to the PR branch, let's wait for the tests results and see if everything is green. |
The tests executed after merging
I've never seen this test failing on this line before... After re-running I got a green run. I would suggest merging this PR and observing if the mentioned issue appear again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All righty let's do this thing!
## What's Changed * Revert "Debounce dispatched state diffs" by @jagodarybacka in #3569 * Fix failing e2e by @michalinacienciala in #3567 * v0.43.1 by @hyphenized in #3563 * v0.43.2 by @hyphenized in #3566 **Full Changelog**: v0.43.2...v0.43.3 Latest build: [extension-builds-3570](https://github.com/tahowallet/extension/suites/14531806692/artifacts/822103324) (as of Mon, 24 Jul 2023 20:41:47 GMT).
The e2e tests (regular and fork-based) were failing on the
main
branch. This PR incorporates a couple changes that fix:RECOVERY_PHRASE environment variable is not defined.
error ine2e-tests
jobunzip: cannot find or open chrome-fork.zip, chrome-fork.zip.zip or chrome-fork.zip.ZIP.
error ine2e-tests-fork
job.The PR does not address the following problems (we'll deal with them separately):
Transaction signed, broadcasting...
not being visible duringUser can send base asset
test ine2e-tests-fork
job. (Possibly an issue with cache or caused b the same issue as mentioned in the point below)Expected pattern: /^Ethereum$/
vsReceived string: ""
inUser can open ERC-20 transfer from asset list and can reject the transfer
test ine2e-tests-fork
job. (Actual bug with rejecting txs - Extension tx screen re-opening after approving / rejecting tx #2876 - Reject button needs to be clicked twice)Latest build: extension-builds-3567 (as of Mon, 24 Jul 2023 18:35:33 GMT).