Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing e2e #3567

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Fix failing e2e #3567

merged 3 commits into from
Jul 24, 2023

Conversation

michalinacienciala
Copy link
Contributor

@michalinacienciala michalinacienciala commented Jul 24, 2023

The e2e tests (regular and fork-based) were failing on the main branch. This PR incorporates a couple changes that fix:

  • The issue with RECOVERY_PHRASE environment variable is not defined. error in e2e-tests job
  • The issue with unzip: cannot find or open chrome-fork.zip, chrome-fork.zip.zip or chrome-fork.zip.ZIP. error in e2e-tests-fork job.

The PR does not address the following problems (we'll deal with them separately):

  • The issue with Transaction signed, broadcasting... not being visible during User can send base asset test in e2e-tests-fork job. (Possibly an issue with cache or caused b the same issue as mentioned in the point below)
  • The issue with Expected pattern: /^Ethereum$/ vs Received string: "" in User can open ERC-20 transfer from asset list and can reject the transfer test in e2e-tests-fork job. (Actual bug with rejecting txs - Extension tx screen re-opening after approving / rejecting tx #2876 - Reject button needs to be clicked twice)

Latest build: extension-builds-3567 (as of Mon, 24 Jul 2023 18:35:33 GMT).

michalinacienciala and others added 2 commits July 24, 2023 10:45
The variable is needed by the `e2e-tests/regular/transactions.spec.ts` test.
We changed this for production fork builds to differentiate from the release builds, and we updated e2e tests to look for the suffix, but on non release branches the fork builds were not getting the suffix, leading to test failures.
@michalinacienciala michalinacienciala marked this pull request as ready for review July 24, 2023 11:24
@michalinacienciala michalinacienciala requested review from Shadowfiend and a team July 24, 2023 11:25
@michalinacienciala
Copy link
Contributor Author

It's likely that the two remaining problems will be fixed by #3569. I merged this change to the PR branch, let's wait for the tests results and see if everything is green.

@michalinacienciala
Copy link
Contributor Author

It's likely that the two remaining problems will be fixed by #3569. I merged this change to the PR branch, let's wait for the tests results and see if everything is green.

The tests executed after merging main to the feature branch have failed on one test in Onboarding:

1) [chromium] › onboarding.spec.ts:7:7 › Onboarding › User can onboard a read-only address ───────

    locator.innerText: Target closed
    =========================== logs ===========================
    waiting for getByTestId('wallet_balance')
    ============================================================

      21 |     }).toPass()
      22 |
    > 23 |     expect(popup.getByTestId("wallet_balance").innerText()).not.toContain("$0")
         |                                                ^
      24 |   })
      25 |
      26 |   test("User can onboard with a existing seed-phrase", async ({

        at /home/runner/work/extension/extension/e2e-tests/regular/onboarding.spec.ts:[23](https://github.com/tahowallet/extension/actions/runs/5648091731/job/15299648051#step:9:24):48

I've never seen this test failing on this line before...

After re-running I got a green run. I would suggest merging this PR and observing if the mentioned issue appear again.

Copy link
Contributor

@Shadowfiend Shadowfiend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All righty let's do this thing!

@Shadowfiend Shadowfiend merged commit c9ceeed into main Jul 24, 2023
6 checks passed
@Shadowfiend Shadowfiend deleted the fix-failing-e2e branch July 24, 2023 19:14
@hyphenized hyphenized mentioned this pull request Jul 24, 2023
Shadowfiend added a commit that referenced this pull request Jul 25, 2023
## What's Changed
* Revert "Debounce dispatched state diffs" by @jagodarybacka in
#3569
* Fix failing e2e by @michalinacienciala in
#3567
* v0.43.1 by @hyphenized in
#3563
* v0.43.2 by @hyphenized in
#3566


**Full Changelog**:
v0.43.2...v0.43.3

Latest build:
[extension-builds-3570](https://github.com/tahowallet/extension/suites/14531806692/artifacts/822103324)
(as of Mon, 24 Jul 2023 20:41:47 GMT).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants