Fix assertions made on the latest transaction #3573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a stage in the tests when we want to verify the attributes of the latest transaction. By mistake we did some of the checks on an objet that wasn't a latest transaction, but on an object of 'any' transaction. The assertion was failing if more than one object was detected.
Merged
jagodarybacka
added a commit
that referenced
this pull request
Aug 2, 2023
## What's Changed * v0.43.3 by @hyphenized in #3570 * Use JSON onboarding in e2e tests of transactions by @michalinacienciala in #3559 * Refactor prices caching by @hyphenized in #3526 * Fix assertions made on the latest transaction by @michalinacienciala in #3573 **Full Changelog**: v0.43.3...v0.44.0 Latest build: [extension-builds-3577](https://github.com/tahowallet/extension/suites/14645396551/artifacts/830824018) (as of Fri, 28 Jul 2023 14:43:48 GMT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a stage in the tests when we want to verify the attributes of the latest transaction. By mistake we did some of the checks on an objet that wasn't a latest transaction, but on an object of 'any' transaction. The assertion was failing if more than one object was detected.
Latest build: extension-builds-3573 (as of Thu, 27 Jul 2023 08:58:29 GMT).