v0.46.0 #3596

Shadowfiend · 2023-08-09T14:25:49Z

Primarily a bug fix release for dApp connections in certain scenarios, particularly stargate.finance .

What's Changed

v0.45.0 by @jagodarybacka in v0.45.0 #3589
Add @testing-library/dom to background by @jagodarybacka in Add @testing-library/dom to background #3588
Modify Hardhat cache config by @michalinacienciala in Modify Hardhat cache config #3591
Revolintion: Apply most of the @thesis-co/eslint-config lint styling to the extension by @Shadowfiend in Revolintion: Apply most of the @thesis-co/eslint-config lint styling to the extension #3571
Release Checklist Update: Added Flashbots by @andreachapman in Release Checklist Update: Added Flashbots #3592
DAppstrosities: Fix a few observed dApp connection issues by @Shadowfiend in DAppstrosities: Fix a few observed dApp connection issues #3593

Full Changelog: v0.45.0...v0.46.0

Latest build: extension-builds-3596 (as of Wed, 09 Aug 2023 20:24:30 GMT).

github-actions · 2023-08-09T14:26:07Z

Release checklist

This release checklist should be performed before release is published.

dev tests should be performed by the dev team
if something is not working please create an issue and link it here. Checkbox should be checked only if everything was fine
in case of serious issues or doubts you should ask the team first

Don't forget to approve the PR when checklist is finished ✅

Dev tests

🚀 Version update

update from previous version with some accounts loaded

Manual tests

📨 Add account

Add read-only account with ENS
- check assets
- check balance
- check NFTs
- check abilities (abilities should not be displayed)
- check activities
- check portfolio page
- check export options (export recovery phase and export private key should not be available)
Add read-only account with UNS
- check assets
- check balance
- check NFTs
- check abilities (abilities should not be displayed)
- check activities
- check portfolio page
- check export options (export recovery phase and export private key should not be available)
Add read-only account with 0x address
- check assets
- check balance
- check NFTs
- check abilities (abilities should not be displayed)
- check activities
- check portfolio page
- check export options (export recovery phase and export private key should not be available)
Import account with a seed phrase
- check assets
- check balance
- check NFTs
- check abilities
- check activities
- check portfolio page
- check seed phrase export
- check private key export for first account
Add another account from the same seed phrase
- check assets
- check balance
- check NFTs
- check abilities
- check activities
- check portfolio page
- check private key export for second account
Add account with a Ledger
- check assets
- check balance
- check NFTs
- check abilities
- check activities
- check portfolio page
- check export options (export recovery phase and export private key should not be available)
Create new wallet
- check assets
- check balance
- check NFTs
- check abilities
- check activities
- check portfolio page
- check private key export
Add account with private key
- check assets
- check balance
- check NFTs
- check abilities
- check activities
- check portfolio page
- check private key export
Add account with JSON keystore
- check assets
- check balance
- check NFTs
- check abilities
- check activities
- check portfolio page
- check private key export

🗑️ Remove account

Remove account by type
- [ x] remove read-only account
- remove address from imported account
- remove Ledger account
- remove account imported with private key
- remove account imported with JSON keystore
- remove selected account
- remove not selected account
- remove all accounts
Remove account and check functionalities
- add removed address from imported account
- remove all addresses from imported account
- check if NFTs are removed for removed accounts
- check if abilities are removed for removed accounts
- check if Portfolio page is updated for removed accounts

💌 Send base asset

Ethereum mainnet
- check gas settings and gas price
- sign
- check transaction on scan website
Polygon
- check gas settings and gas price
- sign
- check transaction on scan website
Optimism
- check gas settings and gas price
- sign
- check transaction on scan website
Arbitrum
- check gas settings and gas price
- sign
- check transaction on scan website
Avalanche
- check gas settings and gas price
- sign
- check transaction on scan website
Binance Smart Chain
- check gas settings and gas price
- sign
- check transaction on scan website

🎁 Send ERC20

Ethereum mainnet
- check gas settings and gas price
- sign
- check transaction on scan website
Polygon
- check gas settings and gas price
- sign
- check transaction on scan website
Optimism
- check gas settings and gas price
- sign
- check transaction on scan website
Arbitrum
- check gas settings and gas price
- sign
- check transaction on scan website
Avalanche
- check gas settings and gas price
- sign
- check transaction on scan website
Binance Smart Chain
- check gas settings and gas price
- sign
- check transaction on scan website

💸 Internal swap

Ethereum mainnet
- check token list
- sign token spend approval
- check gas settings and gas price
- sign
- check transaction on scan website
Polygon
- check token list
- sign token spend approval
- check gas settings and gas price
- sign
- check transaction on scan website
Optimism
- check token list
- sign token spend approval
- check gas settings and gas price
- sign
- check transaction on scan website
Arbitrum
- check token list
- sign token spend approval
- check gas settings and gas price
- sign
- check transaction on scan website
Avalanche
- check token list
- sign token spend approval
- check gas settings and gas price
- sign
- check transaction on scan website
Binance Smart Chain
- check token list
- sign token spend approval
- check gas settings and gas price
- sign
- check transaction on scan website

📡 dApps connections

connect to Uniswap
connect to Opensea
connect to Galxe
connect to PancakeSwap
connect to TraderJoe
connect to SpookySwap
connect to Velodrome
connect to GMX
connect to Mintkudos - site is sunset though so nothing to do here. Need to replace with a different site to check.

🎭 Sign in with Ethereum

SIWE on login.xyz
SIWE on Taho Pledge

🐶 Default wallet

Default wallet setting turned OFF
- connect with dapp without MM available using Taho
- connect with dapp with MM available using MM
Default wallet setting turned ON
- connect with dapp without MM available using Taho
- connect with dapp with MM available using Taho

⚙️ Settings

check hide balance under $2 option
check bug reports - export logs
check connected dapp - confirm you are able to disconnect from a dapp

☀️ Abilities

check each filter option
delete ability
mark ability as completed

🌠 NFTs page

NFTs page
- browse NFTs
- expand and collapse collection
- check NFT preview
- check Badges tab
NFTs filters
- check each sort type
- disable account
- disable collection

🦾 Flashbots

Enable Flashbots in settings:
- send/swap an asset & confirm trxn on Ethereum shows the Flashbots option with it auto-selected
- confirm trxn is then sent through Flashbots
- send/swap another asset deselect Flashbots option
- confirm that trxn is not sent through Flashbots
Check trxns on other networks
- confirm Flashbots checkbox isn't shown at all
- confirm trxn is not sent through Flashbots
Disable Flashbots option in settings
- send/swap an asset on Ethereum & confirm trxn shows without the Flashbots option
- confirm trxn is not sent through Flashbots

Shadowfiend · 2023-08-09T16:45:24Z

Intent here is to merge this and then do a patch release with #3597 and possibly an additional fix for dApp connections when using the MetaMask mock provider.

Shadowfiend · 2023-08-09T20:19:55Z

Merging this as-is, then pulling checklists over for a 0.46.1 release.

@hyphenized

Additional fix for issues on the signing screen from #3571. ## What's Changed (since v0.45.0) * Fix invalid react fragment by @hyphenized in #3597 * v0.46.0 by @Shadowfiend in #3596 * v0.45.0 by @jagodarybacka in #3589 * Add `@testing-library/dom` to `background` by @jagodarybacka in #3588 * Modify Hardhat cache config by @michalinacienciala in #3591 * Revolintion: Apply most of the `@thesis-co/eslint-config` lint styling to the extension by @Shadowfiend in #3571 * Release Checklist Update: Added Flashbots by @andreachapman in #3592 * DAppstrosities: Fix a few observed dApp connection issues by @Shadowfiend in #3593 **Full Changelog**: v0.45.0...v0.46.0 Latest build: [extension-builds-3598](https://github.com/tahowallet/extension/suites/14964619550/artifacts/853742841) (as of Wed, 09 Aug 2023 22:44:33 GMT).

v0.46.0

a976945

Merge branch 'main' into release-0.46.0

e902ae6

Shadowfiend merged commit ca0eb8b into main Aug 9, 2023
3 of 4 checks passed

Shadowfiend deleted the release-0.46.0 branch August 9, 2023 20:20

Shadowfiend mentioned this pull request Aug 9, 2023

v0.46.1 #3598

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v0.46.0 #3596

v0.46.0 #3596

Shadowfiend commented Aug 9, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Aug 9, 2023 •

edited by andreachapman

Loading

Shadowfiend commented Aug 9, 2023

Shadowfiend commented Aug 9, 2023

v0.46.0 #3596

v0.46.0 #3596

Conversation

Shadowfiend commented Aug 9, 2023 • edited by github-actions bot Loading

What's Changed

github-actions bot commented Aug 9, 2023 • edited by andreachapman Loading

Release checklist

Dev tests

🚀 Version update

Manual tests

📨 Add account

🗑️ Remove account

💌 Send base asset

🎁 Send ERC20

💸 Internal swap

📡 dApps connections

🎭 Sign in with Ethereum

🐶 Default wallet

⚙️ Settings

☀️ Abilities

🌠 NFTs page

🦾 Flashbots

Shadowfiend commented Aug 9, 2023

Shadowfiend commented Aug 9, 2023

Shadowfiend commented Aug 9, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Aug 9, 2023 •

edited by andreachapman

Loading