Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.46.1 #3598

Merged
merged 1 commit into from
Aug 11, 2023
Merged

v0.46.1 #3598

merged 1 commit into from
Aug 11, 2023

Conversation

Shadowfiend
Copy link
Contributor

@Shadowfiend Shadowfiend commented Aug 9, 2023 •
edited by github-actions bot
Loading

Additional fix for issues on the signing screen from #3571.

What's Changed (since v0.45.0)

Full Changelog: v0.45.0...v0.46.0

Latest build: extension-builds-3598 (as of Wed, 09 Aug 2023 22:44:33 GMT).

@github-actions
Copy link

github-actions bot commented Aug 9, 2023 •
edited by Shadowfiend
Loading

Release checklist

This release checklist should be performed before release is published.

  • dev tests should be performed by the dev team
  • if something is not working please create an issue and link it here. Checkbox should be checked only if everything was fine
  • in case of serious issues or doubts you should ask the team first

Don't forget to approve the PR when checklist is finished ✅

Dev tests

🚀 Version update

  • update from previous version with some accounts loaded

Manual tests

📨 Add account

  1. Add read-only account with ENS
    • check assets
    • check balance
    • check NFTs
    • check abilities (abilities should not be displayed)
    • check activities
    • check portfolio page
    • check export options (export recovery phase and export private key should not be available)
  2. Add read-only account with UNS
    • check assets
    • check balance
    • check NFTs
    • check abilities (abilities should not be displayed)
    • check activities
    • check portfolio page
    • check export options (export recovery phase and export private key should not be available)
  3. Add read-only account with 0x address
    • check assets
    • check balance
    • check NFTs
    • check abilities (abilities should not be displayed)
    • check activities
    • check portfolio page
    • check export options (export recovery phase and export private key should not be available)
  4. Import account with a seed phrase
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check seed phrase export
    • check private key export for first account
  5. Add another account from the same seed phrase
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check private key export for second account
  6. Add account with a Ledger
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check export options (export recovery phase and export private key should not be available)
  7. Create new wallet
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check private key export
  8. Add account with private key
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check private key export
  9. Add account with JSON keystore
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check private key export

🗑️ Remove account

  1. Remove account by type
    • remove read-only account
    • remove address from imported account
    • remove Ledger account
    • remove account imported with private key
    • remove account imported with JSON keystore
    • remove selected account
    • remove not selected account
    • remove all accounts
  2. Remove account and check functionalities
    • add removed address from imported account
    • remove all addresses from imported account
    • check if NFTs are removed for removed accounts
    • check if abilities are removed for removed accounts
    • check if Portfolio page is updated for removed accounts

💌 Send base asset

  1. Ethereum mainnet
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  2. Polygon
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain
    • check gas settings and gas price
    • sign
    • check transaction on scan website

🎁 Send ERC20

  1. Ethereum mainnet
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  2. Polygon
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain
    • check gas settings and gas price
    • sign
    • check transaction on scan website

💸 Internal swap

  1. Ethereum mainnet
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  2. Polygon
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website

📡 dApps connections

🎭 Sign in with Ethereum

🐶 Default wallet

  1. Default wallet setting turned OFF
    • connect with dapp without MM available using Taho
    • connect with dapp with MM available using MM
  2. Default wallet setting turned ON
    • connect with dapp without MM available using Taho
    • connect with dapp with MM available using Taho

⚙️ Settings

  • check hide balance under $2 option
  • check bug reports - export logs
  • check connected dapp - confirm you are able to disconnect from a dapp

☀️ Abilities

  • check each filter option
  • delete ability
  • mark ability as completed

🌠 NFTs page

  1. NFTs page
    • browse NFTs
    • expand and collapse collection
    • check NFT preview
    • check Badges tab
  2. NFTs filters
    • check each sort type
    • disable account
    • disable collection

🦾 Flashbots

  1. Enable Flashbots in settings:
    • send/swap an asset & confirm trxn on Ethereum shows the Flashbots option with it auto-selected
    • confirm trxn is then sent through Flashbots
    • send/swap another asset deselect Flashbots option
    • confirm that trxn is not sent through Flashbots
  2. Check trxns on other networks
    • confirm Flashbots checkbox isn't shown at all
    • confirm trxn is not sent through Flashbots
  3. Disable Flashbots option in settings
    • send/swap an asset on Ethereum & confirm trxn shows without the Flashbots option
    • confirm trxn is not sent through Flashbots

andreachapman
andreachapman approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@andreachapman andreachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist complete except the one item under the dev tests section.

@Shadowfiend
Copy link
Contributor Author

e2e-tests are failing for an unrelated reason that I've tracked down, will handle that separately.

@Shadowfiend Shadowfiend merged commit 6b8e4b0 into main Aug 11, 2023
12 of 13 checks passed
@Shadowfiend Shadowfiend deleted the release-0.46.1 branch August 11, 2023 14:32
@Shadowfiend Shadowfiend mentioned this pull request Aug 15, 2023
Merged
Shadowfiend added a commit that referenced this pull request Aug 17, 2023
@Shadowfiend
v0.47.0 (#3601)
e6df3e0 
## Highlights

- Further performance improvements.
- Groundwork to rename backend dApp connection things (for the provider)
to Taho naming.

## What's Changed
* v0.46.1 by @Shadowfiend in
#3598
* Updates to release checklist: Removed Mintkudos test by @andreachapman
in #3600
* Revert "Revert "Debounce dispatched state diffs"" by @hyphenized in
#3579
* Underbridge: Drop updated dApp connections feature flag, further Taho
renames by @Shadowfiend in
#3595


**Full Changelog**:
v0.46.1...v0.47.0

Latest build:
[extension-builds-3601](https://github.com/tahowallet/extension/suites/15160003504/artifacts/866327987)
(as of Wed, 16 Aug 2023 19:09:51 GMT).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreachapman andreachapman andreachapman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shadowfiend @andreachapman