Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show wallet address after hovering on wallet name #3713

Closed
wants to merge 1 commit into from
Closed

Conversation

xpaczka
Copy link
Contributor

@xpaczka xpaczka commented Dec 19, 2023

Resolves #3171

What has been done

  • Show address to be copies in "Copy address" tooltip
  • In filters on account list hover, show the truncated address (instead of ens/uns name)

Testing

  • Hover over item on accounts list in filters - address shows

Zrzut ekranu 2023-12-19 o 11 29 19

Latest build: extension-builds-3713 (as of Thu, 21 Dec 2023 09:31:19 GMT).

@jagodarybacka
Copy link
Contributor

image

Oh I think that it doesn't make sense to show the tooltip with the actual address here - it makes UI less readable IMO compared to having copy address CTA. Other places that were mentioned in the issue make more sense. We also have a component that will allow to copy address on click - like here:
image

I think we should be using this component wherever possible and show ENS/UNS instead of the short address - it makes the UI more user friendly and easier to work with.

@xpaczka xpaczka reopened this Dec 20, 2023
@Shadowfiend Shadowfiend closed this Oct 6, 2024
@Shadowfiend Shadowfiend deleted the address-hover branch October 6, 2024 17:27
@Shadowfiend
Copy link
Contributor

Not relevant atm, let's clean it up. We can restore later if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show wallet address after hovering on wallet name
3 participants