Changed the build for the firefox browser #3733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… alternatives to docker
Shadowfiend
reviewed
Jan 30, 2024
There was a problem hiding this comment.
This is fairly well-contained. In general we haven't been supporting Firefox, and I don't expect we'll have the bandwidth to do it moving forward—are you willing to maintain this longer term? We'll probably merge it regardless, but want to add a note that it doesn't have an assigned maintainer.
|
As I understand it, you want to compete with metamask, which means you need to be on firefox. |
Shadowfiend
approved these changes
Apr 13, 2024
Merged
Shadowfiend
added a commit
that referenced
this pull request
Oct 5, 2024
## What's Changed * v0.57.0 by @Shadowfiend in #3735 * Support for Wallet Test Framework by @SamWilsn in #3737 * Fix typos by @omahs in #3724 * Fix a couple of typos from contribution by @Shadowfiend in #3742 * Move action using node12 to a newer version by @michalinacienciala in #3722 * Changed the build for the firefox browser by @kogeletey in #3733 * Remove Goerli testnet from the testnets list by @michalinacienciala in #3718 * Move autolock timer by @radchukd in #3743 * Tweaks and creaks: Disable UNS, fix Ledger signing on built-in non-ETH/MATIC networks by @Shadowfiend in #3746 ## New Contributors * @SamWilsn made their first contribution in #3737 * @kogeletey made their first contribution in #3733 * @radchukd made their first contribution in #3743 Latest build: [extension-builds-3747](https://github.com/tahowallet/extension/suites/26032567144/artifacts/1703810792) (as of Mon, 15 Jul 2024 21:35:33 GMT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In new versions the extension was simply not built for this browser.
Changed the build scripts and made them cross-managers.
Now it can be compiled not only by docker.
In general, everything works, except probably the main thing - sign in at dapps.
If it ever gets fixed it will be great
Latest build: extension-builds-3733 (as of Sat, 13 Apr 2024 20:16:37 GMT).