From 2f2e137d4a2393aac1b2dfbcd18708c44074df7c Mon Sep 17 00:00:00 2001 From: Antonio Salazar Cardozo Date: Sat, 13 Apr 2024 13:53:13 -0400 Subject: [PATCH] Fix a couple of typos from contribution Because these touch some core files, we rewrite them from scratch. Co-authored-by: goodmost Co-authored-by: snoppy --- background/lib/tests/utils.unit.test.ts | 2 +- background/services/internal-signer/encryption.ts | 2 +- provider-bridge/README.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/background/lib/tests/utils.unit.test.ts b/background/lib/tests/utils.unit.test.ts index 0ce3f6d084..3452ec2d80 100644 --- a/background/lib/tests/utils.unit.test.ts +++ b/background/lib/tests/utils.unit.test.ts @@ -140,7 +140,7 @@ describe("Lib Utils", () => { ) it.each(nonZeroWithLeadingZeros)( - "given number >=1 with leading zeros should should truncate at desired length", + "given number >=1 with leading zeros should truncate at desired length", ({ value, decimalLength, maxDecimalLength, expected }) => { expect( truncateDecimalAmount(value, decimalLength, maxDecimalLength), diff --git a/background/services/internal-signer/encryption.ts b/background/services/internal-signer/encryption.ts index 0dce01e4dc..a5847542f3 100644 --- a/background/services/internal-signer/encryption.ts +++ b/background/services/internal-signer/encryption.ts @@ -62,7 +62,7 @@ function requireCryptoGlobal(message?: string) { * been one before. If no salt is provided, a random salt will be * generated. * - * Note that the the symmetric, alone, or the salt *and* the password, + * Note that the symmetric key, alone, or the salt *and* the password, * together, must be retained to decrypt anything encrypted by the * returned key. While the salt isn't secret key material, losing it * could jeopardize access to user data (and therefor, funds). diff --git a/provider-bridge/README.md b/provider-bridge/README.md index 1b41ca8ded..a84b0797e6 100644 --- a/provider-bridge/README.md +++ b/provider-bridge/README.md @@ -55,7 +55,7 @@ - eg webextension-polyfill is 37KB which is comparable to the size spa web framewoks. > It's absolutely fine for now bc this way we get to use the same apis everywhere but good thing to have this consideration in the back of our minds - implement injection restrictions (only valid html files, blacklists?) -- add message validaition mechanism to postMessage/addEventListener used in inpage<>content comm (signing, enveloping, asymmetric encryption etc. Can be as simple as a "parity bit") +- add message validation mechanism to postMessage/addEventListener used in inpage<>content comm (signing, enveloping, asymmetric encryption etc. Can be as simple as a "parity bit") ## window.ethereum debug