Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple of typos from contribution #3742

Merged
merged 1 commit into from
Apr 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion background/lib/tests/utils.unit.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ describe("Lib Utils", () => {
)

it.each(nonZeroWithLeadingZeros)(
"given number >=1 with leading zeros should should truncate at desired length",
"given number >=1 with leading zeros should truncate at desired length",
({ value, decimalLength, maxDecimalLength, expected }) => {
expect(
truncateDecimalAmount(value, decimalLength, maxDecimalLength),
Expand Down
2 changes: 1 addition & 1 deletion background/services/internal-signer/encryption.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ function requireCryptoGlobal(message?: string) {
* been one before. If no salt is provided, a random salt will be
* generated.
*
* Note that the the symmetric, alone, or the salt *and* the password,
* Note that the symmetric key, alone, or the salt *and* the password,
* together, must be retained to decrypt anything encrypted by the
* returned key. While the salt isn't secret key material, losing it
* could jeopardize access to user data (and therefor, funds).
Expand Down
2 changes: 1 addition & 1 deletion provider-bridge/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
- eg webextension-polyfill is 37KB which is comparable to the size spa web framewoks.
> It's absolutely fine for now bc this way we get to use the same apis everywhere but good thing to have this consideration in the back of our minds
- implement injection restrictions (only valid html files, blacklists?)
- add message validaition mechanism to postMessage/addEventListener used in inpage<>content comm (signing, enveloping, asymmetric encryption etc. Can be as simple as a "parity bit")
- add message validation mechanism to postMessage/addEventListener used in inpage<>content comm (signing, enveloping, asymmetric encryption etc. Can be as simple as a "parity bit")

## window.ethereum debug

Expand Down
Loading