Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move autolock timer #3743

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Conversation

radchukd
Copy link
Contributor

@radchukd radchukd commented Apr 21, 2024

Resolves #3572

What

Move auto-lock timer
autolock

Fix SharedSelect trigger z-index
settings

Fix OnboardingDerivationPathSelect width
width

Latest build: extension-builds-3743 (as of Mon, 15 Jul 2024 01:43:14 GMT).

Fix SharedSelect trigger z-index
Fix OnboardingDerivationPathSelect width
Copy link
Contributor

@Shadowfiend Shadowfiend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite ready to merge here as I'm worried that the z-index will have unintended side-effects. In particular, this z-index was introduced in 8cf22e4, which handled the slippage tolerance dropdown for swaps—wondering if removing it creates problems there.

ui/components/Shared/SharedSelect.tsx Show resolved Hide resolved
ui/pages/Onboarding/Tabbed/ImportSeed.tsx Show resolved Hide resolved
ui/pages/Settings.tsx Show resolved Hide resolved
Copy link
Contributor

@Shadowfiend Shadowfiend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All righty let's land this, sorry for the delay here.

@Shadowfiend Shadowfiend merged commit 0024916 into tahowallet:main Jul 15, 2024
5 of 6 checks passed
@Shadowfiend Shadowfiend mentioned this pull request Jul 15, 2024
Shadowfiend added a commit that referenced this pull request Oct 5, 2024
## What's Changed
* v0.57.0 by @Shadowfiend in
#3735
* Support for Wallet Test Framework by @SamWilsn in
#3737
* Fix typos by @omahs in
#3724
* Fix a couple of typos from contribution by @Shadowfiend in
#3742
* Move action using node12 to a newer version by @michalinacienciala in
#3722
* Changed the build for the firefox browser by @kogeletey in
#3733
* Remove Goerli testnet from the testnets list by @michalinacienciala in
#3718
* Move autolock timer by @radchukd in
#3743
* Tweaks and creaks: Disable UNS, fix Ledger signing on built-in
non-ETH/MATIC networks by @Shadowfiend in
#3746

## New Contributors
* @SamWilsn made their first contribution in
#3737
* @kogeletey made their first contribution in
#3733
* @radchukd made their first contribution in
#3743

Latest build:
[extension-builds-3747](https://github.com/tahowallet/extension/suites/26032567144/artifacts/1703810792)
(as of Mon, 15 Jul 2024 21:35:33 GMT).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings: Move auto lock timer
2 participants