Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weaken errors related to rustc version to warnings #407

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Dec 21, 2024

Context: https://discord.com/channels/273534239310479360/957720175619215380/1318211522287243295 by @Nemo157

That error is so that users who do not read the documentation that says the flag requires a nightly compiler or warning that says it may not work with this toolchain version, do not waste their time.

However, this does not interact well with the use case of wanting to manipulate the compiler output to fool “only" the build script, so this check needs to be weakened to a warning.

@taiki-e taiki-e merged commit 9897df5 into main Dec 21, 2024
25 checks passed
@taiki-e taiki-e deleted the version-warn branch December 21, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant