You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the solution you'd like
we can improve it by converting Provider and DBProvider into an enum as was suggested in the PR #1125 for IntegrationProvider
Why should we implement this?
It would reduce code duplication and runtime errors, for ex: instead of hard-coding the values like 'postgres' we can import the enum and reference the property name as shown in the screenshot below:
Would you like to work on this issue?
Yes, once approved I'll start working on it.
The text was updated successfully, but these errors were encountered:
Hey, thank you for opening your first Issue! 🙂 While a Tailwarden team member takes a look at your issue we would like to invite you to join our official Discord server, where you can interact directly with other contributors and Tailwarden team members. Link here: https://discord.tailwarden.com
Is your feature request related to a problem? Please describe.
Currently there is a lot of duplicated code as you can see below:
komiser/dashboard/utils/providerHelper.ts
Lines 1 to 57 in 5983512
Describe the solution you'd like
we can improve it by converting Provider and DBProvider into an enum as was suggested in the PR #1125 for IntegrationProvider
komiser/dashboard/utils/providerHelper.ts
Lines 57 to 62 in 5983512
Why should we implement this?
It would reduce code duplication and runtime errors, for ex: instead of hard-coding the values like 'postgres' we can import the enum and reference the property name as shown in the screenshot below:
Would you like to work on this issue?
Yes, once approved I'll start working on it.
The text was updated successfully, but these errors were encountered: