Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest tailwind css v3.3.3 #1013

Closed

Conversation

shivam-sharma7
Copy link
Contributor

use latest tailwind css v3.3.3

[Provide a brief description of the problem that you are trying to solve with this pull request.]

Solution

[Provide a detailed explanation of the solution you are proposing, including any relevant code snippets or screenshots.]

Changes Made

  • [List the changes you made in this pull request, including any new features or bug fixes.]

How to Test

[Provide instructions on how to test the changes you made, including any relevant details like configuration steps or data to be used for testing.]

Screenshots

[Include screenshots, if relevant, to help reviewers understand the changes you made.]

Notes

[Any additional notes or information that you would like to share with the reviewers.]

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

@shivam-sharma7 shivam-sharma7 changed the title use latest tailwind css v3.3.3 Use latest tailwind css v3.3.3 Oct 2, 2023
@AvineshTripathi
Copy link
Collaborator

I am not really sure if updating versions manually is better I think updates should be done when required or those that comes with some changes and while doing the changes version updates directly. Thoughts? cc @Traxmaxx

@Kolawole99
Copy link
Contributor

I agree with @AvineshTripathi on manually updating packages, we should either find a way to automate this or schedule a time for updating packages.

@Traxmaxx
Copy link
Contributor

Traxmaxx commented Oct 2, 2023

Correct me if I'm wrong but dependabot is taking care of package upgrades in this repo right?

While I agree that packages should be upgraded rather sooner than later, just upgrading them for the purpose of upgrading is defeting the purpose I feel. For example while tailwindcss got upgraded in this PR, why is prettier-plugin-tailwindcss still on ^0.2.2 while the latest release is 0.5.4? Also the PR desciption is not filled out properly and I don't understand why this upgrade is being done.

@AvineshTripathi
Copy link
Collaborator

Agreed on that @Traxmaxx

@shivam-sharma7 I dont find this to be a PR that we can merge based on above discussion let me know if we can close this PR

@shivam-sharma7 shivam-sharma7 deleted the tailwind-css branch October 2, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants