feat: Fix cost calculations for AWS S3 #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
bishal7679
requested review from
mlabouardy,
ShubhamPalriwala,
AvineshTripathi,
greghub and
Traxmaxx
as code owners
|
/cc @AvineshTripathi |
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
bishal7679
force-pushed
the
feature/correct-cost-for-s3
branch
from
9ea9e1d
to
eeef8dc
Compare
|
@Azanul @AvineshTripathi PHAL! |
Azanul
requested changes
Oct 9, 2023
Azanul
reviewed
Oct 9, 2023
Azanul
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
I think the code comments are pretty obvious and can be removed. Thanks for the work @bishal7679
mlabouardy
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Thanks for the changes @bishal7679 once the comments are removed, I'll merge the PR :)
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
bishal7679
force-pushed
the
feature/correct-cost-for-s3
branch
from
263305c
to
66b6a6c
Compare
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
|
All good to go now 👍 @mlabouardy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem #1022
Currently cost for AWS S3 is always showing as $0.
Solution
This PR is fixing that issue by adding more filters and usage metrics for request to s3 bucket with absolute pricemap fetching.
Changes Made
AmazonS3service code and appropriate filters.Screenshots
Checklist
Taking ref from :- #1053