Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Util funcs #1090

Merged
merged 3 commits into from
Oct 15, 2023
Merged

Util funcs #1090

merged 3 commits into from
Oct 15, 2023

Conversation

Azanul
Copy link
Collaborator

@Azanul Azanul commented Oct 13, 2023

Problem

Util functions are very limited, GetPriceMap has the limitation of using only "group" attribute for using as price map key.

Solution

Introduction of a new argument field in the util function GetPriceMap to make the key dynamic

Notes

Will keep on adding more attributes as the need arrises

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@[username of the reviewer]

Signed-off-by: Azanul <azanulhaque@gmail.com>
@mlabouardy mlabouardy merged commit 9a6974f into tailwarden:develop Oct 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants