feat: integrate formbricks in-app survey #1109
Conversation
ShubhamPalriwala
requested review from
mlabouardy,
AvineshTripathi,
greghub and
Traxmaxx
as code owners
| formbricks.init({ | ||
| environmentId: 'clnmmpeg01ci3o50fu5wy89zn', | ||
| apiHost: 'https://app.formbricks.com', | ||
| debug: false // remove when in production |
There was a problem hiding this comment.
Wouldn't debug be false for production?
There was a problem hiding this comment.
its false only? i dont understand what you mean?
There was a problem hiding this comment.
The comment says to remove in production
There was a problem hiding this comment.
Why would I remove debug: false in production?
There was a problem hiding this comment.
The debug: false is the same as removing! Its better to keep it as an option as its more verbose and can be enabled anytime if needed! And in my opinion, shouldn't be an issue at all
There was a problem hiding this comment.
Makes sense.
The comment just seemed confusing to me, as why would I be removing debug: false in production. Since as you said it makes no difference.
Wouldn't it make more sense if debug was true with that comment or the comment was not there?
dashboard/pages/_app.tsx
Outdated
| @@ -22,9 +25,25 @@ const printHiringMessage = () => { | |||
|
|
|||
| if (typeof window !== 'undefined') { | |||
| printHiringMessage(); | |||
| formbricks.init({ | |||
| environmentId: 'clnmmpeg01ci3o50fu5wy89zn', | |||
There was a problem hiding this comment.
should we import envId from some external var and not hardcode it
There was a problem hiding this comment.
yep, can we declare it here: https://github.com/tailwarden/komiser/blob/develop/dashboard/environments/environment.ts
There was a problem hiding this comment.
thats not an issue! it isn't sensitive. let me know if y'all still want me to shift it there
There was a problem hiding this comment.
Yes, it is not sensitive, but it would be better to keep config variables outside in a centralized file so we can easily update them :)
There was a problem hiding this comment.
Done, please take a look now
Integrate Formbricks In-App Surveys