-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: changed toast to have centralized state management and sing… #1112
refactor: changed toast to have centralized state management and sing… #1112
Conversation
hei @shavidze thanks so much for your contribution! It looks good already but there are still Toast imports and definitions found throughout the whole application: |
hi @Traxmaxx ,no I've already updated it, I missed to remove it and insert into the provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM really well done! 👏 Thanks for taking the time! 🙏
You can always ask me for help, I'm trying to participate on the server side too 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…leton approach
Problem
Toasts are difficult to use and always need to be imported manually if not already
Solution
Implemented
ToastProvider
, typically provides the same instance of the toast management context throughout the entire application.Checklist
Reviewers
@Traxmaxx