-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs): added maxlength for inputs #876
fix(inputs): added maxlength for inputs #876
Conversation
Hey @shobhitexe great work 🚀 To the point and concise changes!
@mlabouardy what do you think? Or should we tackle this in a separate PR? |
Certainly, it is possible. For instance, a notification similar to this may appear, indicating that the maximum character limit has been reached. what you think |
Yes, lets tackle it in a separate PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @shobhitexe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!🚀 I'll log another issue for adding a toast notification when the character limit exceeds, feel free to take that up!
Problem
Closes #358
There was no maxLength for input fields
Solution
Added maxLength of 64 to inputs
Changes Made
Screenshots
2023-06-30.14-45-23.mp4
Text not going beyond 64 chars same for all inputs
Checklist
Reviewers
@mlabouardy @ShubhamPalriwala