Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs): added maxlength for inputs #876

Merged
merged 2 commits into from
Jul 4, 2023
Merged

fix(inputs): added maxlength for inputs #876

merged 2 commits into from
Jul 4, 2023

Conversation

shobhitexe
Copy link
Contributor

@shobhitexe shobhitexe commented Jun 30, 2023

Problem

Closes #358

There was no maxLength for input fields

Solution

Added maxLength of 64 to inputs

Changes Made

  • Added maxLength prop to input.tsx
  • added maxlength of 64 to input fields

Screenshots

2023-06-30.14-45-23.mp4

Text not going beyond 64 chars same for all inputs

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@mlabouardy @ShubhamPalriwala

@ShubhamPalriwala
Copy link
Contributor

Hey @shobhitexe great work 🚀 To the point and concise changes!
Just a suggestion:

  • Can we throw a warning when the max character limit gets exceeded @shobhitexe? Something like a small warning message just below the input box saying the max character limit to search has exceeded! Prolly playing around mt-2 text-xs text-error-600.

@mlabouardy what do you think? Or should we tackle this in a separate PR?

@shobhitexe
Copy link
Contributor Author

Hey @shobhitexe great work 🚀 To the point and concise changes! Just a suggestion:

  • Can we throw a warning when the max character limit gets exceeded @shobhitexe? Something like a small warning message just below the input box saying the max character limit to search has exceeded! Prolly playing around mt-2 text-xs text-error-600.

@mlabouardy what do you think? Or should we tackle this in a separate PR?

Certainly, it is possible. For instance, a notification similar to this may appear, indicating that the maximum character limit has been reached. what you think
image

@mlabouardy
Copy link
Collaborator

Hey @shobhitexe great work 🚀 To the point and concise changes! Just a suggestion:

  • Can we throw a warning when the max character limit gets exceeded @shobhitexe? Something like a small warning message just below the input box saying the max character limit to search has exceeded! Prolly playing around mt-2 text-xs text-error-600.

@mlabouardy what do you think? Or should we tackle this in a separate PR?

Yes, lets tackle it in a separate PR :)

Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @shobhitexe

@mlabouardy mlabouardy added the ui label Jul 4, 2023
@mlabouardy mlabouardy added this to the v3.0.20 milestone Jul 4, 2023
Copy link
Contributor

@ShubhamPalriwala ShubhamPalriwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!🚀 I'll log another issue for adding a toast notification when the character limit exceeds, feel free to take that up!

@mlabouardy mlabouardy merged commit d4211e5 into tailwarden:develop Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set maxlength for custom view's name input
3 participants